Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: android_webview/browser/shared_renderer_state.h

Issue 1816283005: Move SharedRendererState ownership to AwContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Begin to disentangle SRS and BVR Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/shared_renderer_state.h
diff --git a/android_webview/browser/shared_renderer_state.h b/android_webview/browser/shared_renderer_state.h
index a2313a58ea63dd93c22f729fe75841b29fc953b9..22ef7f81952bddaec7258a66b6ecaccdb4f57f78 100644
--- a/android_webview/browser/shared_renderer_state.h
+++ b/android_webview/browser/shared_renderer_state.h
@@ -19,7 +19,6 @@
#include "ui/gfx/geometry/vector2d.h"
struct AwDrawGLInfo;
-
namespace android_webview {
namespace internal {
@@ -44,24 +43,24 @@ class SharedRendererState {
using ReturnedResourcesMap = std::map<uint32_t, ReturnedResources>;
SharedRendererState(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_loop,
- BrowserViewRenderer* browser_view_renderer);
+ const scoped_refptr<base::SingleThreadTaskRunner>& ui_loop);
~SharedRendererState();
// This function can be called from any thread.
void ClientRequestDrawGL(bool for_idle);
// UI thread methods.
+ void SetBrowserViewRendererOnUI(BrowserViewRenderer* browser_view_renderer);
void SetScrollOffsetOnUI(gfx::Vector2d scroll_offset);
void SetCompositorFrameOnUI(scoped_ptr<ChildFrame> frame);
void InitializeHardwareDrawIfNeededOnUI();
- void ReleaseHardwareDrawIfNeededOnUI();
ParentCompositorDrawConstraints GetParentDrawConstraintsOnUI() const;
void SwapReturnedResourcesOnUI(ReturnedResourcesMap* returned_resource_map);
bool ReturnedResourcesEmptyOnUI() const;
scoped_ptr<ChildFrame> PassUncommittedFrameOnUI();
- void DeleteHardwareRendererOnUI();
bool HasFrameOnUI() const;
+ void TrimMemoryOnUI(int level);
+ void ReleaseCompositorResourcesIfNeededOnUI();
// RT thread methods.
gfx::Vector2d GetScrollOffsetOnRT();
@@ -94,7 +93,6 @@ class SharedRendererState {
void UpdateParentDrawConstraintsOnUI();
bool IsInsideHardwareRelease() const;
void SetInsideHardwareRelease(bool inside);
- void ReleaseCompositorResourcesIfNeededOnUI(bool release_hardware_draw);
// Accessed by UI thread.
scoped_refptr<base::SingleThreadTaskRunner> ui_loop_;

Powered by Google App Engine
This is Rietveld 408576698