android_webview/browser/browser_view_renderer_unittest.cc - Issue 1816283005: Move SharedRendererState ownership to AwContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 1816283005: Move SharedRendererState ownership to AwContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/browser_view_renderer_unittest.cc

diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc

index ffa574296cd0eb96bfc1b2699c2235e9f03ffdce..5f247ba1df96e9b8ec0d028c007c326dde4ddb28 100644

--- a/android_webview/browser/browser_view_renderer_unittest.cc

+++ b/android_webview/browser/browser_view_renderer_unittest.cc

@@ -123,8 +123,10 @@ class TestAnimateInAndOutOfScreen : public RenderingTest {

constraints1.surface_rect_empty == constraints2.surface_rect_empty;

}

- void ParentDrawConstraintsUpdated(

- const ParentCompositorDrawConstraints& constraints) override {

+ void OnParentDrawConstraintsUpdated() override {

+ RenderingTest::OnParentDrawConstraintsUpdated();

+ ParentCompositorDrawConstraints constraints =

+ shared_renderer_state_->GetParentDrawConstraintsOnUI();

switch (on_draw_count_) {

case 1u:

EXPECT_TRUE(DrawConstraintsEquals(constraints, new_constraints_));