Move SharedRendererState ownership to AwContents

android_webview/browser/browser_view_renderer.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
 
 #include <stddef.h>
 
 #include <map>
 
 #include "android_webview/browser/parent_compositor_draw_constraints.h"
 #include "android_webview/browser/shared_renderer_state.h"
 #include "base/callback.h"
 #include "base/cancelable_callback.h"
 #include "base/macros.h"
 #include "base/trace_event/trace_event.h"
+#include "cc/resources/returned_resource.h"

[boliu, 2016/03/30 16:12:13]

header not needed by BVR. Is it used by aw_contents?

[Tobias Sargeant, 2016/03/30 17:17:16]

Removed. Was a leftover from when AwContents used BVR methods to return
resources.

 #include "content/public/browser/android/synchronous_compositor.h"
 #include "content/public/browser/android/synchronous_compositor_client.h"
 #include "skia/ext/refptr.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size_f.h"
 #include "ui/gfx/geometry/vector2d_f.h"
 
 class SkCanvas;
 class SkPicture;
 
@@ skipping 15 matching lines @@
       content::WebContents* web_contents);
 
   BrowserViewRenderer(
       BrowserViewRendererClient* client,
       const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner,
       bool disable_page_visibility);
 
   ~BrowserViewRenderer() override;
 
   void RegisterWithWebContents(content::WebContents* web_contents);
-
-  SharedRendererState* GetAwDrawGLViewContext();
-  bool RequestDrawGL(bool wait_for_completion);
+  void SetSharedRendererState(SharedRendererState* shared_renderer_state);
 
   // Called before either OnDrawHardware or OnDrawSoftware to set the view
   // state of this frame. |scroll| is the view's current scroll offset.
   // |global_visible_rect| is the intersection of the view size and the window
   // in window coordinates.
   void PrepareToDraw(const gfx::Vector2d& scroll,
                      const gfx::Rect& global_visible_rect);
 
   // Main handlers for view drawing. A false return value indicates no new
   // frame is produced.
@@ skipping 24 matching lines @@
 
   // Set the root layer scroll offset to |new_value|.
   void ScrollTo(const gfx::Vector2d& new_value);
 
   // Android views hierarchy gluing.
   bool IsVisible() const;
   gfx::Rect GetScreenRect() const;
   bool attached_to_window() const { return attached_to_window_; }
   bool hardware_enabled() const { return hardware_enabled_; }
   gfx::Size size() const { return size_; }
-  void ReleaseHardware();
 
   bool IsClientVisible() const;
-  void TrimMemory(const int level, const bool visible);
+  void TrimMemory();
 
   // SynchronousCompositorClient overrides.
   void DidInitializeCompositor(
       content::SynchronousCompositor* compositor) override;
   void DidDestroyCompositor(
       content::SynchronousCompositor* compositor) override;
   void DidBecomeCurrent(content::SynchronousCompositor* compositor) override;
   void PostInvalidate() override;
   void DidUpdateContent() override;
   void UpdateRootLayerState(const gfx::Vector2dF& total_scroll_offset_dip,
                             const gfx::Vector2dF& max_scroll_offset_dip,
                             const gfx::SizeF& scrollable_size_dip,
                             float page_scale_factor,
                             float min_page_scale_factor,
                             float max_page_scale_factor) override;
   void DidOverscroll(const gfx::Vector2dF& accumulated_overscroll,
                      const gfx::Vector2dF& latest_overscroll_delta,
                      const gfx::Vector2dF& current_fling_velocity) override;
 
-  void UpdateParentDrawConstraints();
+  void UpdateParentDrawConstraints(const ParentCompositorDrawConstraints&);
   void DetachFunctorFromView();
 
  private:
   void SetTotalRootLayerScrollOffset(const gfx::Vector2dF& new_value_dip);
   bool CanOnDraw();
   void UpdateCompositorIsActive();
   bool CompositeSW(SkCanvas* canvas);
   scoped_ptr<base::trace_event::ConvertableToTraceFormat> RootLayerStateAsValue(
       const gfx::Vector2dF& total_scroll_offset_dip,
       const gfx::SizeF& scrollable_size_dip);
 
   void ReturnUnusedResource(scoped_ptr<ChildFrame> frame);
   void ReturnResourceFromParent();
 
   gfx::Vector2d max_scroll_offset() const;
 
   void UpdateMemoryPolicy();
 
   uint32_t GetCompositorID(content::SynchronousCompositor* compositor);
   // For debug tracing or logging. Return the string representation of this
   // view renderer's state.
   std::string ToString() const;
 
-  BrowserViewRendererClient* client_;
-  SharedRendererState shared_renderer_state_;
-  scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
+  BrowserViewRendererClient* const client_;
+  const scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
+  SharedRendererState* shared_renderer_state_;
   bool disable_page_visibility_;
 
   // The current compositor that's owned by the current RVH.
   content::SynchronousCompositor* compositor_;
   // A map from compositor's per-WebView unique ID to the compositor's raw
   // pointer. A raw pointer here is fine because the entry will be erased when
   // a compositor is destroyed.
   std::map<size_t, content::SynchronousCompositor*> compositor_map_;
 
   bool is_paused_;
@@ skipping 26 matching lines @@
   gfx::Vector2dF max_scroll_offset_dip_;
 
   // Used to prevent rounding errors from accumulating enough to generate
   // visible skew (especially noticeable when scrolling up and down in the same
   // spot over a period of time).
   // TODO(miletus): Make overscroll_rounding_error_ a gfx::ScrollOffset.
   gfx::Vector2dF overscroll_rounding_error_;
 
   uint32_t next_compositor_id_;
 
+  ParentCompositorDrawConstraints external_draw_constraints_;
+
   DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer);
 };
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_