Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: android_webview/browser/shared_renderer_state.cc

Issue 1816283005: Move SharedRendererState ownership to AwContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/shared_renderer_state.h" 5 #include "android_webview/browser/shared_renderer_state.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/browser_view_renderer.h" 9 #include "android_webview/browser/browser_view_renderer.h"
10 #include "android_webview/browser/child_frame.h" 10 #include "android_webview/browser/child_frame.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 } // namespace internal 80 } // namespace internal
81 81
82 namespace { 82 namespace {
83 83
84 base::LazyInstance<internal::RequestDrawGLTracker> g_request_draw_gl_tracker = 84 base::LazyInstance<internal::RequestDrawGLTracker> g_request_draw_gl_tracker =
85 LAZY_INSTANCE_INITIALIZER; 85 LAZY_INSTANCE_INITIALIZER;
86 86
87 } 87 }
88 88
89 SharedRendererState::SharedRendererState( 89 SharedRendererState::SharedRendererState(
90 const scoped_refptr<base::SingleThreadTaskRunner>& ui_loop, 90 const scoped_refptr<base::SingleThreadTaskRunner>& ui_loop)
91 BrowserViewRenderer* browser_view_renderer)
92 : ui_loop_(ui_loop), 91 : ui_loop_(ui_loop),
93 browser_view_renderer_(browser_view_renderer), 92 browser_view_renderer_(nullptr),
94 renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()), 93 renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()),
95 hardware_renderer_has_frame_(false), 94 hardware_renderer_has_frame_(false),
96 inside_hardware_release_(false), 95 inside_hardware_release_(false),
97 weak_factory_on_ui_thread_(this) { 96 weak_factory_on_ui_thread_(this) {
98 DCHECK(ui_loop_->BelongsToCurrentThread()); 97 DCHECK(ui_loop_->BelongsToCurrentThread());
99 DCHECK(browser_view_renderer_);
100 ui_thread_weak_ptr_ = weak_factory_on_ui_thread_.GetWeakPtr(); 98 ui_thread_weak_ptr_ = weak_factory_on_ui_thread_.GetWeakPtr();
101 ResetRequestDrawGLCallback(); 99 ResetRequestDrawGLCallback();
102 } 100 }
103 101
104 SharedRendererState::~SharedRendererState() { 102 SharedRendererState::~SharedRendererState() {
105 DCHECK(ui_loop_->BelongsToCurrentThread()); 103 DCHECK(ui_loop_->BelongsToCurrentThread());
106 DCHECK(!hardware_renderer_.get()); 104 DCHECK(!hardware_renderer_.get());
107 } 105 }
108 106
109 void SharedRendererState::ClientRequestDrawGL(bool for_idle) { 107 void SharedRendererState::ClientRequestDrawGL(bool for_idle) {
(...skipping 25 matching lines...) Expand all
135 void SharedRendererState::ResetRequestDrawGLCallback() { 133 void SharedRendererState::ResetRequestDrawGLCallback() {
136 DCHECK(ui_loop_->BelongsToCurrentThread()); 134 DCHECK(ui_loop_->BelongsToCurrentThread());
137 base::AutoLock lock(lock_); 135 base::AutoLock lock(lock_);
138 request_draw_gl_cancelable_closure_.Reset(base::Bind( 136 request_draw_gl_cancelable_closure_.Reset(base::Bind(
139 &SharedRendererState::ClientRequestDrawGLOnUI, base::Unretained(this))); 137 &SharedRendererState::ClientRequestDrawGLOnUI, base::Unretained(this)));
140 request_draw_gl_closure_ = request_draw_gl_cancelable_closure_.callback(); 138 request_draw_gl_closure_ = request_draw_gl_cancelable_closure_.callback();
141 } 139 }
142 140
143 void SharedRendererState::ClientRequestDrawGLOnUI() { 141 void SharedRendererState::ClientRequestDrawGLOnUI() {
144 DCHECK(ui_loop_->BelongsToCurrentThread()); 142 DCHECK(ui_loop_->BelongsToCurrentThread());
143 DCHECK(browser_view_renderer_);
145 ResetRequestDrawGLCallback(); 144 ResetRequestDrawGLCallback();
146 g_request_draw_gl_tracker.Get().SetQueuedFunctorOnUi(this); 145 g_request_draw_gl_tracker.Get().SetQueuedFunctorOnUi(this);
147 if (!browser_view_renderer_->RequestDrawGL(false)) { 146 if (!browser_view_renderer_->RequestDrawGL(false)) {
148 g_request_draw_gl_tracker.Get().ResetPending(); 147 g_request_draw_gl_tracker.Get().ResetPending();
149 LOG(ERROR) << "Failed to request GL process. Deadlock likely"; 148 LOG(ERROR) << "Failed to request GL process. Deadlock likely";
150 } 149 }
151 } 150 }
152 151
153 void SharedRendererState::UpdateParentDrawConstraintsOnUI() { 152 void SharedRendererState::UpdateParentDrawConstraintsOnUI() {
154 DCHECK(ui_loop_->BelongsToCurrentThread()); 153 DCHECK(ui_loop_->BelongsToCurrentThread());
154 DCHECK(browser_view_renderer_);
155 browser_view_renderer_->UpdateParentDrawConstraints(); 155 browser_view_renderer_->UpdateParentDrawConstraints();
156 } 156 }
157 157
158 void SharedRendererState::SetBrowserViewRendererOnUI(
159 BrowserViewRenderer* browser_view_renderer) {
160 DCHECK(ui_loop_->BelongsToCurrentThread());
161 browser_view_renderer_ = browser_view_renderer;
162 }
163
158 void SharedRendererState::SetScrollOffsetOnUI(gfx::Vector2d scroll_offset) { 164 void SharedRendererState::SetScrollOffsetOnUI(gfx::Vector2d scroll_offset) {
159 base::AutoLock lock(lock_); 165 base::AutoLock lock(lock_);
160 scroll_offset_ = scroll_offset; 166 scroll_offset_ = scroll_offset;
161 } 167 }
162 168
163 gfx::Vector2d SharedRendererState::GetScrollOffsetOnRT() { 169 gfx::Vector2d SharedRendererState::GetScrollOffsetOnRT() {
164 base::AutoLock lock(lock_); 170 base::AutoLock lock(lock_);
165 return scroll_offset_; 171 return scroll_offset_;
166 } 172 }
167 173
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 ReleaseCompositorResourcesIfNeededOnUI(true); 324 ReleaseCompositorResourcesIfNeededOnUI(true);
319 } 325 }
320 326
321 void SharedRendererState::DeleteHardwareRendererOnUI() { 327 void SharedRendererState::DeleteHardwareRendererOnUI() {
322 ReleaseCompositorResourcesIfNeededOnUI(false); 328 ReleaseCompositorResourcesIfNeededOnUI(false);
323 } 329 }
324 330
325 void SharedRendererState::ReleaseCompositorResourcesIfNeededOnUI( 331 void SharedRendererState::ReleaseCompositorResourcesIfNeededOnUI(
326 bool release_hardware_draw) { 332 bool release_hardware_draw) {
327 DCHECK(ui_loop_->BelongsToCurrentThread()); 333 DCHECK(ui_loop_->BelongsToCurrentThread());
334 DCHECK(browser_view_renderer_);
328 InsideHardwareReleaseReset auto_inside_hardware_release_reset(this); 335 InsideHardwareReleaseReset auto_inside_hardware_release_reset(this);
329 336
330 browser_view_renderer_->DetachFunctorFromView(); 337 browser_view_renderer_->DetachFunctorFromView();
331 bool hardware_initialized = browser_view_renderer_->hardware_enabled(); 338 bool hardware_initialized = browser_view_renderer_->hardware_enabled();
332 // If the WebView gets onTrimMemory >= MODERATE twice in a row, the 2nd 339 // If the WebView gets onTrimMemory >= MODERATE twice in a row, the 2nd
333 // onTrimMemory will result in an unnecessary Render Thread DrawGL call. 340 // onTrimMemory will result in an unnecessary Render Thread DrawGL call.
334 if (hardware_initialized) { 341 if (hardware_initialized) {
335 bool draw_functor_succeeded = browser_view_renderer_->RequestDrawGL(true); 342 bool draw_functor_succeeded = browser_view_renderer_->RequestDrawGL(true);
336 if (!draw_functor_succeeded) { 343 if (!draw_functor_succeeded) {
337 LOG(ERROR) << "Unable to free GL resources. Has the Window leaked?"; 344 LOG(ERROR) << "Unable to free GL resources. Has the Window leaked?";
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 : shared_renderer_state_(shared_renderer_state) { 388 : shared_renderer_state_(shared_renderer_state) {
382 DCHECK(!shared_renderer_state_->IsInsideHardwareRelease()); 389 DCHECK(!shared_renderer_state_->IsInsideHardwareRelease());
383 shared_renderer_state_->SetInsideHardwareRelease(true); 390 shared_renderer_state_->SetInsideHardwareRelease(true);
384 } 391 }
385 392
386 SharedRendererState::InsideHardwareReleaseReset::~InsideHardwareReleaseReset() { 393 SharedRendererState::InsideHardwareReleaseReset::~InsideHardwareReleaseReset() {
387 shared_renderer_state_->SetInsideHardwareRelease(false); 394 shared_renderer_state_->SetInsideHardwareRelease(false);
388 } 395 }
389 396
390 } // namespace android_webview 397 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698