Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1816283003: chrome style plugin: Don't crash when checking class weight. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
vmpstr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome style plugin: Don't crash when checking class weight. It's impossible to determine if an incomplete type has a trivial destructor when counting the 'weight' of a class' fields, so check if the type has a definition first. BUG=595786 Committed: https://crrev.com/e264c3e8bdfc81c21ad0248624e5f2d67007450a Cr-Commit-Position: refs/heads/master@{#382695}

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : Add test comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 2 chunks +8 lines, -10 lines 0 comments Download
A tools/clang/plugins/tests/class_with_incomplete_type.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A + tools/clang/plugins/tests/class_with_incomplete_type.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tools/clang/plugins/tests/class_with_incomplete_type.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 9 months ago (2016-03-22 20:09:48 UTC) #2
vmpstr
lgtm
4 years, 9 months ago (2016-03-22 21:03:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816283003/40001
4 years, 9 months ago (2016-03-22 21:14:21 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 21:56:46 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 21:59:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e264c3e8bdfc81c21ad0248624e5f2d67007450a
Cr-Commit-Position: refs/heads/master@{#382695}

Powered by Google App Engine
This is Rietveld 408576698