Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1816283002: Fix compile errors when DEBUG_AUDIONODE_REFERENCES is set. (Closed)

Created:
4 years, 9 months ago by Raymond Toy
Modified:
4 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compile errors when DEBUG_AUDIONODE_REFERENCES is set. BUG=596649 TEST=Change DEBUG_AUDIONODE_REFERENCES to 1 in AudioNode.h and compile Committed: https://crrev.com/139db7daa31f10c5d136d058ef1995868c7d25dd Cr-Commit-Position: refs/heads/master@{#382414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raymond Toy
PTAL
4 years, 9 months ago (2016-03-21 20:53:05 UTC) #2
hongchan
lgtm
4 years, 9 months ago (2016-03-21 20:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816283002/1
4 years, 9 months ago (2016-03-21 21:01:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 22:14:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 22:16:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/139db7daa31f10c5d136d058ef1995868c7d25dd
Cr-Commit-Position: refs/heads/master@{#382414}

Powered by Google App Engine
This is Rietveld 408576698