third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1816253002: Move grid-template-columns/grid-template-rows into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1816253002: Move grid-template-columns/grid-template-rows into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index 474576738139b147fc5b4b7e8db7e05c1340d6b7..ac6476947d2d4b96e830cd4d4c46017713f04943 100644

--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -265,12 +265,6 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::legacyParseValue(CSSProperty

parsedValue = parseGridAutoFlow(*m_valueList);

break;

- case CSSPropertyGridTemplateColumns:

- case CSSPropertyGridTemplateRows:

- ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());

- parsedValue = parseGridTrackList();

- break;

case CSSPropertyGridTemplateAreas:

ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());

parsedValue = parseGridTemplateAreas();

@@ -539,7 +533,7 @@ bool CSSPropertyParser::parseGridLineNames(CSSParserValueList& inputList, CSSVal

return true;

}

-static bool allTracksAreFixedSized(CSSValueList& valueList)

+bool allTracksAreFixedSized(CSSValueList& valueList)

{

for (auto value : valueList) {

if (value->isGridLineNamesValue())

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »