Update SkSpecialImage to be able to create tight SkImages and SkSurfaces

Update SkSpecialImage to be able to create tight SkImages and SkSurfaces

This calved off of: https://codereview.chromium.org/1810693003/ (Switch SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter needs a tight bitmap/texture/image to perform its draw.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1816223002

Committed: https://skia.googlesource.com/skia/+/b4bd11e66519f545282f914c67b54bf17cecab84

[robertphillips, 2016-03-21 18:46:34]

Description was changed from

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces
==========

to

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-21 18:48:22]

Description was changed from

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces

This calved off of: https://codereview.chromium.org/1810693003/ (Switch
SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter
needs a tight bitmap/texture/image to perform its draw.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-21 18:48:22]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2016-03-21 19:50:08]

lgtm but wondering if it'd be clearer to rename the existing factory methods
makeSpecial* and remove the "Tight" from the new ones.

[robertphillips, 2016-03-21 20:17:04]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 20:17:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816223002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816223002/100001

[reed1, 2016-03-21 20:18:01]

https://codereview.chromium.org/1816223002/diff/80001/src/core/SkSpecialImage...
File src/core/SkSpecialImage.cpp (right):

https://codereview.chromium.org/1816223002/diff/80001/src/core/SkSpecialImage...
src/core/SkSpecialImage.cpp:44: virtual SkSurface* onMakeTightSurface(const
SkImageInfo& info) const = 0;
why is this * and not sp?

[commit-bot: I haz the power, 2016-03-21 20:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:28:05]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-21 20:43:10]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-21 20:43:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1816223002/#ps100001
(title: "Rm ' '")

[commit-bot: I haz the power, 2016-03-21 20:43:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816223002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816223002/100001

[commit-bot: I haz the power, 2016-03-21 20:44:22]

Description was changed from

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces

This calved off of: https://codereview.chromium.org/1810693003/ (Switch
SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter
needs a tight bitmap/texture/image to perform its draw.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkSpecialImage to be able to create tight SkImages and SkSurfaces

This calved off of: https://codereview.chromium.org/1810693003/ (Switch
SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter
needs a tight bitmap/texture/image to perform its draw.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b4bd11e66519f545282f914c67b54bf17cecab84
==========

[commit-bot: I haz the power, 2016-03-21 20:44:23]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/b4bd11e66519f545282f914c67b54bf17cecab84

[robertphillips, 2016-03-21 20:48:37]

https://codereview.chromium.org/1816223002/diff/80001/src/core/SkSpecialImage...
File src/core/SkSpecialImage.cpp (right):

https://codereview.chromium.org/1816223002/diff/80001/src/core/SkSpecialImage...
src/core/SkSpecialImage.cpp:44: virtual SkSurface* onMakeTightSurface(const
SkImageInfo& info) const = 0;
On 2016/03/21 20:18:01, reed1 wrote:
> why is this * and not sp?

I answered this off-line. Right now, SkSurface's factories return raw pointers.
Having the raw->sk_sp swap occur in one place (i.e., makeTightSurface) should
make swapping over to smart pointers easier.