content/common/gpu/media/v4l2_video_decode_accelerator.cc - Issue 1816203003: Add an additional VDA::Flush() mode to return all allocated buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.cc

Issue 1816203003: Add an additional VDA::Flush() mode to return all allocated buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc ('k') | content/common/gpu/media/vaapi_video_decode_accelerator.cc » ('j') | media/video/video_decode_accelerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_video_decode_accelerator.cc

index fe0343faff95517ec75e8c70a92099798eda939c..5fbb516919a9db1d60606a6384d67490a43ac688 100644

--- a/content/common/gpu/media/v4l2_video_decode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.cc

@@ -222,6 +222,11 @@ bool V4L2VideoDecodeAccelerator::Initialize(const Config& config,

return false;

}

+ if (config.flush_mode != Config::FlushMode::KEEP_OUTPUT_BUFFERS) {

+ NOTIMPLEMENTED() << "Modes other than KEEP_OUTPUT_BUFFERS not implemented";

+ return false;

+ }

if (get_gl_context_cb_.is_null() || make_context_current_cb_.is_null()) {

NOTREACHED() << "GL callbacks are required for this VDA";

return false;