content/common/gpu/media/fake_video_decode_accelerator.cc - Issue 1816203003: Add an additional VDA::Flush() mode to return all allocated buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/fake_video_decode_accelerator.cc

Issue 1816203003: Add an additional VDA::Flush() mode to return all allocated buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/fake_video_decode_accelerator.h ('k') | content/common/gpu/media/gpu_video_decode_accelerator.h » ('j') | content/common/gpu/media/video_decode_accelerator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/fake_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/fake_video_decode_accelerator.cc b/content/common/gpu/media/fake_video_decode_accelerator.cc

index 230c4f34c86e48bbf2f73e852a7297cc4ae6c3af..e0fddeaf930fc69f6723b4b280ecd4c437400948 100644

--- a/content/common/gpu/media/fake_video_decode_accelerator.cc

+++ b/content/common/gpu/media/fake_video_decode_accelerator.cc

@@ -139,7 +139,7 @@ void FakeVideoDecodeAccelerator::ReusePictureBuffer(int32_t picture_buffer_id) {

weak_this_factory_.GetWeakPtr()));

}

-void FakeVideoDecodeAccelerator::Flush() {

+void FakeVideoDecodeAccelerator::Flush(bool return_buffers) {

kcwu 2016/03/22 09:47:42 how about adding DCHECK(!return_buffers) for VDAs

flushing_ = true;

child_task_runner_->PostTask(

FROM_HERE, base::Bind(&FakeVideoDecodeAccelerator::DoPictureReady,