Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1816173004: Capture icu data file name on failure to load (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 8 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Capture icu data file name on failure to load R=jshin@chromium.org BUG=445616 Committed: https://crrev.com/7dc1e9455370951699669006ee082acf6e6cdc11 Cr-Commit-Position: refs/heads/master@{#383769}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M base/i18n/icu_util.cc View 1 4 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
4 years, 9 months ago (2016-03-21 20:09:43 UTC) #1
jungshik at Google
Oops. Sorry for the delay. LGTM
4 years, 9 months ago (2016-03-25 20:02:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816173004/20001
4 years, 8 months ago (2016-03-29 16:59:01 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 18:04:27 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 18:05:52 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7dc1e9455370951699669006ee082acf6e6cdc11
Cr-Commit-Position: refs/heads/master@{#383769}

Powered by Google App Engine
This is Rietveld 408576698