Issue 181613006: Promise.all and Promise.race use "then" rather than "chain".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181613006: Promise.all and Promise.race use "then" rather than "chain". (Closed)

Created:
6 years, 9 months ago by yhirano

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Promise.all and Promise race should use "then" rather than "chain". As specified, they should unwrap resolution values recursively. BUG=347427 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19752

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/promise.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

yhirano

> I will add tests for them soon. https://codereview.chromium.org/182713002/ includes the test for this issue.

6 years, 9 months ago (2014-02-27 07:37:09 UTC) #2

rossberg

6 years, 9 months ago (2014-03-10 11:52:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19752 (presubmit successful).