Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 1816123002: Add testing for subscription from service workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments incorporated and all tests working Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_provider.cc
diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc
index 254d855106bd9466a87c7009f3dff7f01609c275..91f0fafccd64a811f1e6cce7f355ef9d97e67b66 100644
--- a/content/child/push_messaging/push_provider.cc
+++ b/content/child/push_messaging/push_provider.cc
@@ -77,7 +77,8 @@ void PushProvider::subscribe(
GetServiceWorkerRegistrationId(service_worker_registration);
PushSubscriptionOptions content_options;
content_options.user_visible_only = options.userVisibleOnly;
- content_options.sender_info = options.applicationServerKey.utf8();
+
+ content_options.sender_info = options.applicationServerKey.latin1();
Michael van Ouwerkerk 2016/03/30 09:50:04 Could you please document why this must be latin1
harkness 2016/03/30 10:51:49 Done.
thread_safe_sender_->Send(new PushMessagingHostMsg_SubscribeFromWorker(
request_id, service_worker_registration_id, content_options));
}

Powered by Google App Engine
This is Rietveld 408576698