Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1816113002: [crankshaft] Always generate lazy bailout points for tail calls ... (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Always generate lazy bailout points for tail calls ... ... because Debugger could still require them to inspect optimized frames. BUG=chromium:596473, v8:4698 LOG=N Committed: https://crrev.com/66e22b79e812437aa3be168da4612e64a2de6728 Cr-Commit-Position: refs/heads/master@{#34979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -60 lines) Patch
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816113002/1
4 years, 9 months ago (2016-03-21 14:33:17 UTC) #3
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-21 14:33:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 16:56:47 UTC) #9
Benedikt Meurer
LGTM.
4 years, 9 months ago (2016-03-22 07:53:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816113002/1
4 years, 9 months ago (2016-03-22 08:11:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816113002/1
4 years, 9 months ago (2016-03-22 08:12:12 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 08:13:13 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 08:15:52 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66e22b79e812437aa3be168da4612e64a2de6728
Cr-Commit-Position: refs/heads/master@{#34979}

Powered by Google App Engine
This is Rietveld 408576698