Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1816103002: Clear baseComputedStyle when text-autosizing changes. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
drott, pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear baseComputedStyle when text-autosizing changes. baseComputedStyle is an optimization for animations where the computed style before animations are applied is cached and cloned to have cheaper style recalcs for per-frame animation changes. An assumption is that the computed style for the layout object only changes in styleForElement or pseudoStyleForElement. That assumption is not true for text autosizing as the computed style may be changed during layout. Then, for the next animation frame, the text autosizing factor may be different even though the style has not been marked for recalc, and the sanity check for an unchanged baseComputedStyle will trigger an assert. Make sure we clear the baseComputedStyle for an element when the text autosizing factor changes. R=pdr@chromium.org,drott@chromium.org BUG=596018 Committed: https://crrev.com/32a7b19e92a9ff0fca3aba45c1fdd3896fdd5f1d Cr-Commit-Position: refs/heads/master@{#382350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/text-autosizing/basecomputedstyle-assert.html View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text-autosizing/basecomputedstyle-assert-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816103002/1
4 years, 9 months ago (2016-03-21 14:23:19 UTC) #2
rune
ptal
4 years, 9 months ago (2016-03-21 14:34:36 UTC) #3
drott
Non-owner LGTM, I would recommend pdr or someone with text-autosizing experience to do a final ...
4 years, 9 months ago (2016-03-21 15:19:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/120241)
4 years, 9 months ago (2016-03-21 16:11:37 UTC) #6
pdr.
On 2016/03/21 at 16:11:37, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
4 years, 9 months ago (2016-03-21 17:49:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816103002/1
4 years, 9 months ago (2016-03-21 18:36:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 19:17:30 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:20:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32a7b19e92a9ff0fca3aba45c1fdd3896fdd5f1d
Cr-Commit-Position: refs/heads/master@{#382350}

Powered by Google App Engine
This is Rietveld 408576698