Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1816083002: Re-land fix display of wheel event listeners on a page. (Closed)

Created:
4 years, 9 months ago by dtapuska
Modified:
4 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land fix display of wheel event listeners on a page. Fields were getting duplicated for scrollbars. Mark the entire inner viewport as blocked on scroll if we have a wheel listener we don't need to iterate the tree. This was reverted in https://codereview.chromium.org/1816723003 because the sheriff thought it caused a build failure; but the actual failure was from merge of https://chromium.googlesource.com/chromium/src/+/58cef5be289f5004932682c17694aaa7724bae70 and subsequent fix https://chromium.googlesource.com/chromium/src/+/98aba017dee34d0c08df009095e1fe7bbd6acb49 BUG=595591 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=aelias@chromium.org Committed: https://crrev.com/1936b3f6dcdd44c9a7db4e1686437568a7dd1aad Cr-Commit-Position: refs/heads/master@{#382295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M cc/debug/debug_rect_history.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/debug_rect_history.cc View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816083002/1
4 years, 9 months ago (2016-03-21 14:54:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:45:53 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:46:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1936b3f6dcdd44c9a7db4e1686437568a7dd1aad
Cr-Commit-Position: refs/heads/master@{#382295}

Powered by Google App Engine
This is Rietveld 408576698