Issue 181603002: Fix patch creation in merge-to-branch script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181603002: Fix patch creation in merge-to-branch script. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach

Modified:
6 years, 10 months ago

Reviewers:
ulan, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix patch creation in merge-to-branch script. Patch white space got stripped, which lead to failures when applying the patch. - Refine test to reveal the problem - Create a separate method for retrieving the patch that doesn't strip white space R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19566

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	tools/push-to-trunk/git_recipes.py	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 10 months ago (2014-02-26 16:12:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19566 (tree was closed).

Expand Messages | Collapse Messages