Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1816023002: Revert of Update V8 DEPS. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/1824563002/ ) Reason for revert: ICU breakage. Original issue's description: > Update V8 DEPS. > > Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347 > > Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d > > TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/1d6dba43c2b61900be68777297634e05d479a25a > Cr-Commit-Position: refs/heads/master@{#34914} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/27bce81995ea895713e5b78d061ce44e2ef335af Cr-Commit-Position: refs/heads/master@{#34915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of Update V8 DEPS.
4 years, 9 months ago (2016-03-21 05:32:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816023002/1
4 years, 9 months ago (2016-03-21 05:33:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 05:33:22 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 05:34:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27bce81995ea895713e5b78d061ce44e2ef335af
Cr-Commit-Position: refs/heads/master@{#34915}

Powered by Google App Engine
This is Rietveld 408576698