Remove deprecated QTKit Video Capture Support

Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931
Committed: https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf
Cr-Commit-Position: refs/heads/master@{#384206}

[perkj_chrome, 2016-03-20 20:14:24]

Description was changed from

==========
Remove deprecated QTKit VideoCaptureSupport


BUG=
==========

to

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.


BUG=578277, 582931
==========

[perkj_chrome, 2016-03-20 20:14:24]

perkj@chromium.org changed reviewers:
+ tommi@chromium.org

[perkj_chrome, 2016-03-20 20:14:49]

please?

[tommi (sloooow) - chröme, 2016-03-20 22:37:45]

looks like you need to rebase :)

https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
File content/browser/media/media_internals_unittest.cc (right):

https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
content/browser/media/media_internals_unittest.cc:183: "dummy", "dummy",
media::VideoCaptureDevice::Name::AVFOUNDATION),
does this mean the test never ran with avfoundation or is this just mock?

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_factory_mac.mm (right):

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_factory_mac.mm:105: }
looks like the indent is off

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_factory_mac.mm:116:
GetDeviceNames(device_names.get());
out of curiosity, what thread are we running on here?

[perkj_chrome, 2016-03-21 09:45:40]

PTAL - I will fix the broken test in next round. Looks like I set the test
epectations to "AVFoundation" but should be "AV Foundation"

https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
File content/browser/media/media_internals_unittest.cc (right):

https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
content/browser/media/media_internals_unittest.cc:183: "dummy", "dummy",
media::VideoCaptureDevice::Name::AVFOUNDATION),
On 2016/03/20 22:37:44, tommi-chromium wrote:
> does this mean the test never ran with avfoundation or is this just mock?

It fills the device_info struct used by the test. So yes, its a platform
specific mock that just tested one version of on MAC. I think that is ok.

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
File media/capture/video/mac/video_capture_device_factory_mac.mm (right):

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_factory_mac.mm:105: }
On 2016/03/20 22:37:44, tommi-chromium wrote:
> looks like the indent is off 

git cl format missed does not think this is off. Weird. But manually fixing the
indentation and then running git cl format does not revert the manual change....

https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
media/capture/video/mac/video_capture_device_factory_mac.mm:116:
GetDeviceNames(device_names.get());
On 2016/03/20 22:37:44, tommi-chromium wrote:
> out of curiosity, what thread are we running on
here?https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/renderer_host/media/video_capture_manager.cc&rcl=1458530990&l=233

device_task_runnner_ which we changed to be the UI thread on MAC. Also,
AVFoundationGlue is stored in TLS now...

[perkj_chrome, 2016-03-21 16:26:30]

On 2016/03/21 09:45:40, perkj_chrome wrote:
> PTAL - I will fix the broken test in next round. Looks like I set the test
> epectations to "AVFoundation" but should be "AV Foundation"
> 
>
https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
> File content/browser/media/media_internals_unittest.cc (right):
> 
>
https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
> content/browser/media/media_internals_unittest.cc:183: "dummy", "dummy",
> media::VideoCaptureDevice::Name::AVFOUNDATION),
> On 2016/03/20 22:37:44, tommi-chromium wrote:
> > does this mean the test never ran with avfoundation or is this just mock?
> 
> It fills the device_info struct used by the test. So yes, its a platform
> specific mock that just tested one version of on MAC. I think that is ok.
> 
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> File media/capture/video/mac/video_capture_device_factory_mac.mm (right):
> 
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> media/capture/video/mac/video_capture_device_factory_mac.mm:105: }
> On 2016/03/20 22:37:44, tommi-chromium wrote:
> > looks like the indent is off 
> 
> git cl format missed does not think this is off. Weird. But manually fixing
the
> indentation and then running git cl format does not revert the manual
change....
> 
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> media/capture/video/mac/video_capture_device_factory_mac.mm:116:
> GetDeviceNames(device_names.get());
> On 2016/03/20 22:37:44, tommi-chromium wrote:
> > out of curiosity, what thread are we running on
>
here?https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/renderer_host/media/video_capture_manager.cc&rcl=1458530990&l=233
> 
> device_task_runnner_ which we changed to be the UI thread on MAC. Also,
> AVFoundationGlue is stored in TLS now...

And now hopefully fixed the broken test.

[perkj_chrome, 2016-03-22 12:26:41]

On 2016/03/21 16:26:30, perkj_chrome wrote:
> On 2016/03/21 09:45:40, perkj_chrome wrote:
> > PTAL - I will fix the broken test in next round. Looks like I set the test
> > epectations to "AVFoundation" but should be "AV Foundation"
> > 
> >
>
https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
> > File content/browser/media/media_internals_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/1815983003/diff/1/content/browser/media/media...
> > content/browser/media/media_internals_unittest.cc:183: "dummy", "dummy",
> > media::VideoCaptureDevice::Name::AVFOUNDATION),
> > On 2016/03/20 22:37:44, tommi-chromium wrote:
> > > does this mean the test never ran with avfoundation or is this just mock?
> > 
> > It fills the device_info struct used by the test. So yes, its a platform
> > specific mock that just tested one version of on MAC. I think that is ok.
> > 
> >
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> > File media/capture/video/mac/video_capture_device_factory_mac.mm (right):
> > 
> >
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> > media/capture/video/mac/video_capture_device_factory_mac.mm:105: }
> > On 2016/03/20 22:37:44, tommi-chromium wrote:
> > > looks like the indent is off 
> > 
> > git cl format missed does not think this is off. Weird. But manually fixing
> the
> > indentation and then running git cl format does not revert the manual
> change....
> > 
> >
>
https://codereview.chromium.org/1815983003/diff/1/media/capture/video/mac/vid...
> > media/capture/video/mac/video_capture_device_factory_mac.mm:116:
> > GetDeviceNames(device_names.get());
> > On 2016/03/20 22:37:44, tommi-chromium wrote:
> > > out of curiosity, what thread are we running on
> >
>
here?https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/renderer_host/media/video_capture_manager.cc&rcl=1458530990&l=233
> > 
> > device_task_runnner_ which we changed to be the UI thread on MAC. Also,
> > AVFoundationGlue is stored in TLS now...
> 
> And now hopefully fixed the broken test.

If you have time today to review this today - can you also add dcurtis if you
are happy with it? We are not owners in all files it touches.

[perkj_chrome, 2016-03-23 11:47:12]

perkj@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[perkj_chrome, 2016-03-23 11:47:13]

Dale - can you take a look as well?

[DaleCurtis, 2016-03-24 19:08:45]

media/ lgtm -- nice cleanup!

[tommi (sloooow) - chröme, 2016-03-26 18:21:57]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-03-26 18:21:58]

lgtm

[commit-bot: I haz the power, 2016-03-26 18:22:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815983003/60001

[commit-bot: I haz the power, 2016-03-26 18:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 18:30:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[perkj_chrome, 2016-03-28 07:32:35]

perkj@chromium.org changed reviewers:
+ isherman@chromium.org, sky@chromium.org

[perkj_chrome, 2016-03-28 07:32:36]

sky can you please review chrome/ ?
isherman, histograms please?

[Ilya Sherman, 2016-03-28 23:29:08]

histograms.xml lgtm

[perkj_chrome, 2016-03-29 06:32:51]

perkj@chromium.org changed reviewers:
+ jochen@chromium.org

[perkj_chrome, 2016-03-29 06:32:52]

Jochen, any chance you can take a look at the none media changes in chrome/
today? 

Thanks

[sky, 2016-03-30 15:31:05]

https://codereview.chromium.org/1815983003/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1815983003/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6042: +      <message
name="IDS_FLAGS_DISABLE_DELAY_AGNOSTIC_AEC_NAME" desc="Name of the flag for
DA-AEC in WebRTC.">
Why are you adding these new flags?

[perkj_chrome, 2016-03-30 16:44:01]

https://codereview.chromium.org/1815983003/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1815983003/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6042: +      <message
name="IDS_FLAGS_DISABLE_DELAY_AGNOSTIC_AEC_NAME" desc="Name of the flag for
DA-AEC in WebRTC.">
On 2016/03/30 15:31:05, sky wrote:
> Why are you adding these new flags?

Sorry, that was a wast of our time caused by me failing to rebase properly. 
Now fixed.

[jochen (gone - plz use gerrit), 2016-03-30 16:46:59]

deferring to sky@

[sky, 2016-03-31 00:59:57]

LGTM

[perkj_chrome, 2016-03-31 04:39:43]

The CQ bit was checked by perkj@chromium.org

[perkj_chrome, 2016-03-31 04:39:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dalecurtis@chromium.org, tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1815983003/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-03-31 04:39:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815983003/80001

[commit-bot: I haz the power, 2016-03-31 04:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 04:51:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[perkj_chrome, 2016-03-31 06:48:55]

Description was changed from

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.


BUG=578277, 582931
==========

to

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931
==========

[perkj_chrome, 2016-03-31 06:49:56]

Jochen- looks like I still need you for content/browser/BUILD.gn. 
I will TBR for now.

[perkj_chrome, 2016-03-31 06:50:27]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2016-03-31 06:50:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815983003/80001

[commit-bot: I haz the power, 2016-03-31 06:56:42]

Description was changed from

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931
==========

to

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931
==========

[commit-bot: I haz the power, 2016-03-31 06:56:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-31 06:58:12]

Description was changed from

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931
==========

to

==========
Remove deprecated QTKit Video Capture Support
When this cl is landed, Chrome no longer directly link with qtkit.

TBR=jochen@chromium.org  // For content/browser/BUILD.gn
BUG=578277, 582931

Committed: https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf
Cr-Commit-Position: refs/heads/master@{#384206}
==========

[commit-bot: I haz the power, 2016-03-31 06:58:14]

Patchset 5 (id:??) landed as
https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf
Cr-Commit-Position: refs/heads/master@{#384206}