Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1815933002: Fix WebView accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build dependencies Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 8c4f9db408c4d34299f5f513774f89ef338b387b..92466baaf471744dad0071070fcf86088f4200ca 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -743,6 +743,11 @@ INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewTest, testing::Bool());
// These features current would not work with
// --use-cross-process-frames-for-guest and is disabled on
// UseCrossProcessFramesForGuests.
+class WebViewAccessibilityTest : public WebViewTest {};
+INSTANTIATE_TEST_CASE_P(WebViewTests,
+ WebViewAccessibilityTest,
+ testing::Values(false));
+
class WebViewNewWindowTest : public WebViewTest {};
INSTANTIATE_TEST_CASE_P(WebViewTests,
WebViewNewWindowTest,
@@ -2705,6 +2710,35 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, LoadWebviewAccessibleResource) {
"web_view/load_webview_accessible_resource", NEEDS_TEST_SERVER);
}
+IN_PROC_BROWSER_TEST_P(WebViewAccessibilityTest, FocusAccessibility) {
+ LoadAppWithGuest("web_view/focus_accessibility");
+ content::WebContents* web_contents = GetFirstAppWindowWebContents();
+ content::EnableAccessibilityForWebContents(web_contents);
+ content::WebContents* guest_web_contents = GetGuestWebContents();
+ content::EnableAccessibilityForWebContents(guest_web_contents);
+
+ // Wait for focus to land on the "root web area" role, representing
+ // focus on the main document itself.
+ while (content::GetFocusedAccessibilityNodeInfo(web_contents).role !=
+ ui::AX_ROLE_ROOT_WEB_AREA) {
+ content::WaitForAccessibilityFocusChange();
+ }
+
+ // Now keep pressing the Tab key until focus lands on a button.
+ while (content::GetFocusedAccessibilityNodeInfo(web_contents).role !=
+ ui::AX_ROLE_BUTTON) {
+ content::SimulateKeyPress(
+ web_contents, ui::VKEY_TAB, false, false, false, false);
+ content::WaitForAccessibilityFocusChange();
+ }
+
+ // Ensure that we hit the button inside the guest frame labeled
+ // "Guest button".
+ ui::AXNodeData node_data =
+ content::GetFocusedAccessibilityNodeInfo(web_contents);
+ EXPECT_EQ("Guest button", node_data.GetStringAttribute(ui::AX_ATTR_NAME));
+}
+
class WebViewGuestScrollTest
: public WebViewTestBase,
public testing::WithParamInterface<testing::tuple<bool, bool>> {

Powered by Google App Engine
This is Rietveld 408576698