Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 181593004: Encrypted Media: Destroy CDM in ProxyMediaKeys' dtor. (Closed)

Created:
6 years, 9 months ago by xhwang
Modified:
6 years, 9 months ago
Reviewers:
qinmin, ddorwin, dcheng
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, ycheo (away), damienv1, Kibeom Kim (inactive), Ignacio Solla
Visibility:
Public.

Description

Encrypted Media: Destroy CDM in ProxyMediaKeys' dtor. - Makes sure we destroy the CDM when ProxyMediaKeys is destroyed. - Changes MediaKeysHostMsg_CancelAllPendingSessionCreations message to a more general MediaKeysHostMsg_DestroyCdm message and cancels pending session creations as part of OnDestroyCdm(). BUG=347154, 347022 TEST=MediaDrmBridge is properly destroyed with all sessions closed when the MediaPlayer is destroyed. R=dcheng@chromium.org, ddorwin@chromium.org, qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253674

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/proxy_media_keys.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xhwang
https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.h File content/browser/media/android/browser_media_player_manager.h (right): https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.h#newcode140 content/browser/media/android/browser_media_player_manager.h:140: void OnInitializeCDM(int media_keys_id, I'll update CDM to Cdm in ...
6 years, 9 months ago (2014-02-26 18:55:52 UTC) #1
xhwang
qinmin/ddorwin: Please review everything. dcheng: Please OWNERS review media_player_messages_android.h which is a renaming-only change. ycheo/igsolla: ...
6 years, 9 months ago (2014-02-26 18:58:49 UTC) #2
ddorwin
lgtm with comment https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.cc#newcode735 content/browser/media/android/browser_media_player_manager.cc:735: BrowserContext* context = We should either ...
6 years, 9 months ago (2014-02-26 19:09:59 UTC) #3
dcheng
content/common/media/media_player_messages_android.h LGTM
6 years, 9 months ago (2014-02-26 19:11:40 UTC) #4
xhwang
comments addressed
6 years, 9 months ago (2014-02-26 19:18:22 UTC) #5
xhwang
https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/181593004/diff/1/content/browser/media/android/browser_media_player_manager.cc#newcode735 content/browser/media/android/browser_media_player_manager.cc:735: BrowserContext* context = On 2014/02/26 19:10:00, ddorwin wrote: > ...
6 years, 9 months ago (2014-02-26 19:18:58 UTC) #6
qinmin
lgtm
6 years, 9 months ago (2014-02-26 19:42:57 UTC) #7
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 9 months ago (2014-02-26 21:11:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/181593004/2
6 years, 9 months ago (2014-02-26 21:12:15 UTC) #9
xhwang
6 years, 9 months ago (2014-02-27 01:45:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r253674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698