Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 1815863002: Make the config -> pythonish conversion a gclient module function. (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the config -> pythonish conversion a gclient module function. Also makes bot_update use this. This allows for clank to manually set the gclient config. BUG=590788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -36 lines) Patch
M recipe_modules/bot_update/api.py View 3 chunks +1 line, -33 lines 0 comments Download
M recipe_modules/gclient/api.py View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
martiniss
PTAL
4 years, 9 months ago (2016-03-18 22:48:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815863002/1
4 years, 9 months ago (2016-03-18 22:48:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 22:51:01 UTC) #6
hinoka
lgtm
4 years, 9 months ago (2016-03-18 23:12:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815863002/1
4 years, 9 months ago (2016-03-18 23:17:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 23:19:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299398

Powered by Google App Engine
This is Rietveld 408576698