Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1815833002: Rebaseline, fix, or remove various tests dealing with V8 behavior (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline, fix, or remove various tests dealing with V8 behavior Most tests were simply rebaselined. The Date test needed a slight tweak to go from "failing" to "passing" (along with a rebaseline). As for the 'const' tests, they were all testing "legacy" const, which stopped shipping in M49 (in preference to ES2015 const), so deletion seemed like the best remedy. BUG=535408, 570391, 574196, 575917, 576574, 592353 Committed: https://crrev.com/ab13ce20b68732da249c769de9409cf82b4511f7 Cr-Commit-Position: refs/heads/master@{#382133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -416 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/const.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/const-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/date-proto-generic-invocation-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/function-bind-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/inc-const-valueOf.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/inc-const-valueOf-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/kde/const.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/kde/const-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/kde/resources/const.js View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/resources/const.js View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/script-tests/date-proto-generic-invocation.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/js/script-tests/inc-const-valueOf.js View 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-events-expected.txt View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 9 months ago (2016-03-18 22:11:37 UTC) #2
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-18 22:15:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815833002/1
4 years, 9 months ago (2016-03-18 22:16:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 23:26:45 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 23:27:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab13ce20b68732da249c769de9409cf82b4511f7
Cr-Commit-Position: refs/heads/master@{#382133}

Powered by Google App Engine
This is Rietveld 408576698