third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1815803003: Move simple methods [T-Z] from WebGraphicsContext3D to GLES2Interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1815803003: Move simple methods [T-Z] from WebGraphicsContext3D to GLES2Interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simples-fplus

Patch Set: simples-tplus: fixed Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index 718e7153c192eb1329d496644479cfa2c58f780c..7899c9a328dc747b9638f8f47ade5d838deab7f9 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -50,7 +50,7 @@ public:

virtual WebGLSharedObject* object() const = 0;

virtual bool isSharedObject(WebGLSharedObject*) const = 0;

virtual bool valid() const = 0;

- virtual void onDetached(WebGraphicsContext3D*) = 0;

+ virtual void onDetached(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*) = 0;

virtual void attach(gpu::gles2::GLES2Interface*, GLenum target, GLenum attachment) = 0;

virtual void unattach(gpu::gles2::GLES2Interface*, GLenum target, GLenum attachment) = 0;

@@ -100,7 +100,7 @@ protected:

explicit WebGLFramebuffer(WebGLRenderingContextBase*);

bool hasObject() const override { return m_object != 0; }

- void deleteObjectImpl(WebGraphicsContext3D*) override;

+ void deleteObjectImpl(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*) override;

private:

WebGLAttachment* getAttachment(GLenum attachment) const;