Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 18158007: Remove redundant set_optimizable() call (Closed)

Created:
7 years, 5 months ago by weiliang.lin2
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Remove redundant set_optimizable() call

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/objects.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
weiliang.lin2
PTAL
7 years, 5 months ago (2013-07-06 13:32:26 UTC) #1
Yang
On 2013/07/06 13:32:26, weiliang.lin2 wrote: > PTAL Drive-by comment: this changes the semantics of set_optimization_disabled ...
7 years, 5 months ago (2013-07-08 09:00:45 UTC) #2
weiliang.lin2
On 2013/07/08 09:00:45, Yang wrote: > On 2013/07/06 13:32:26, weiliang.lin2 wrote: > > PTAL > ...
7 years, 5 months ago (2013-07-08 10:54:19 UTC) #3
weiliang.lin2
7 years, 5 months ago (2013-07-12 07:28:23 UTC) #4
On 2013/07/08 10:54:19, weiliang.lin2 wrote:
> On 2013/07/08 09:00:45, Yang wrote:
> > On 2013/07/06 13:32:26, weiliang.lin2 wrote:
> > > PTAL
> > 
> > Drive-by comment:
> > 
> > this changes the semantics of set_optimization_disabled and its comment
would
> no
> > longer be valid. The current behavior is that if optimization is disabled
for
> > the shared function info, the shared code is also disabled for optimization,
> but
> > if optimization is enabled again for the shared function info, the shared
code
> > is not not automatically enabled as well for optimization.
> > 
> > While the change is fine, it takes away some flexibility and of course the
> > comment needs to be changed.
> 
> Thanks for comments~  Addressed comment
> Yes, you are right. It seems to take away some flexibility although when
> original V8 code changes shared info optimization, it will always change the
> shared code optimizable at the same time.

If this commit is not necessary, just close it.

Powered by Google App Engine
This is Rietveld 408576698