Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1815773002: Remove runtime flags for Proxy and Reflect (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove runtime flags for Proxy and Reflect Both of them shipped in Chrome 49 without incident. Also move relevant tests from harmony/ to es6/. Committed: https://crrev.com/249bf75e0c99c0fee36cfbd09cad428129edd1c1 Cr-Commit-Position: refs/heads/master@{#34964}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -9790 lines) Patch
M BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +93 lines, -121 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/array-isarray.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/array-concat.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/classes-proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/classof-proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-liveedit-new-target-1.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/debug-stepin-proxies.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/instanceof-proxies.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/iteration-semantics.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/new-target.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/object-tostring.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/proxies-accesschecks.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-apply.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-bind.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-construct.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-cross-realm-exception.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/proxies-define-property.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-delete-property.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-example-membrane.js View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/es6/proxies-for.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-function.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/proxies-get.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/proxies-get-own-property-descriptor.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-get-prototype-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-global-reference.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-has.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-has-own-property.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-hash.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-integrity.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-is-extensible.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-json.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-keys.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-object-assign.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-ownkeys.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-prevent-extensions.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-property-is-enumerable.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-prototype-handler-stackoverflow.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/proxies-prototype-target-stackoverflow.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-revocable.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-set.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-set-prototype-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-with.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/proxies-with-unscopables.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-apply.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-construct.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-define-property.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/reflect-get-own-property-descriptor.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-get-prototype-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-own-keys.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/reflect-prevent-extensions.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/reflect-set-prototype-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-2219.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-2225.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-576662.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-cr493566.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-crbug-448730.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-crbug-461520.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-lookup-transition.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/tail-call-proxies.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/for-in-opt.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/array-species.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/debug-stepin-proxies.js View 1 chunk +0 lines, -61 lines 0 comments Download
M test/mjsunit/harmony/exponentiation-operator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-entries.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-get-own-property-descriptors.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-values.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/private-symbols.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/proxies.js View 1 chunk +0 lines, -1506 lines 0 comments Download
D test/mjsunit/harmony/proxies-accesschecks.js View 1 chunk +0 lines, -15 lines 0 comments Download
D test/mjsunit/harmony/proxies-apply.js View 1 chunk +0 lines, -122 lines 0 comments Download
D test/mjsunit/harmony/proxies-bind.js View 1 chunk +0 lines, -137 lines 0 comments Download
D test/mjsunit/harmony/proxies-construct.js View 1 chunk +0 lines, -158 lines 0 comments Download
D test/mjsunit/harmony/proxies-cross-realm-exception.js View 1 chunk +0 lines, -53 lines 0 comments Download
D test/mjsunit/harmony/proxies-define-property.js View 1 chunk +0 lines, -84 lines 0 comments Download
D test/mjsunit/harmony/proxies-delete-property.js View 1 chunk +0 lines, -190 lines 0 comments Download
D test/mjsunit/harmony/proxies-example-membrane.js View 1 chunk +0 lines, -311 lines 0 comments Download
D test/mjsunit/harmony/proxies-for.js View 1 chunk +0 lines, -140 lines 0 comments Download
D test/mjsunit/harmony/proxies-function.js View 1 chunk +0 lines, -768 lines 0 comments Download
D test/mjsunit/harmony/proxies-get.js View 1 chunk +0 lines, -127 lines 0 comments Download
D test/mjsunit/harmony/proxies-get-own-property-descriptor.js View 1 chunk +0 lines, -129 lines 0 comments Download
D test/mjsunit/harmony/proxies-get-prototype-of.js View 1 chunk +0 lines, -93 lines 0 comments Download
D test/mjsunit/harmony/proxies-global-reference.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/harmony/proxies-has.js View 1 chunk +0 lines, -63 lines 0 comments Download
D test/mjsunit/harmony/proxies-has-own-property.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/harmony/proxies-hash.js View 1 chunk +0 lines, -123 lines 0 comments Download
D test/mjsunit/harmony/proxies-integrity.js View 1 chunk +0 lines, -213 lines 0 comments Download
D test/mjsunit/harmony/proxies-is-extensible.js View 1 chunk +0 lines, -74 lines 0 comments Download
D test/mjsunit/harmony/proxies-json.js View 1 chunk +0 lines, -507 lines 0 comments Download
D test/mjsunit/harmony/proxies-keys.js View 1 chunk +0 lines, -41 lines 0 comments Download
D test/mjsunit/harmony/proxies-object-assign.js View 1 chunk +0 lines, -30 lines 0 comments Download
D test/mjsunit/harmony/proxies-ownkeys.js View 1 chunk +0 lines, -96 lines 0 comments Download
D test/mjsunit/harmony/proxies-prevent-extensions.js View 1 chunk +0 lines, -87 lines 0 comments Download
D test/mjsunit/harmony/proxies-property-is-enumerable.js View 1 chunk +0 lines, -30 lines 0 comments Download
D test/mjsunit/harmony/proxies-prototype-handler-stackoverflow.js View 1 chunk +0 lines, -118 lines 0 comments Download
D test/mjsunit/harmony/proxies-prototype-target-stackoverflow.js View 1 chunk +0 lines, -97 lines 0 comments Download
D test/mjsunit/harmony/proxies-revocable.js View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/harmony/proxies-set.js View 1 chunk +0 lines, -312 lines 0 comments Download
D test/mjsunit/harmony/proxies-set-prototype-of.js View 1 chunk +0 lines, -130 lines 0 comments Download
D test/mjsunit/harmony/proxies-with.js View 1 chunk +0 lines, -353 lines 0 comments Download
D test/mjsunit/harmony/proxies-with-unscopables.js View 1 chunk +0 lines, -148 lines 0 comments Download
D test/mjsunit/harmony/reflect.js View 1 chunk +0 lines, -572 lines 0 comments Download
D test/mjsunit/harmony/reflect-apply.js View 1 chunk +0 lines, -212 lines 0 comments Download
D test/mjsunit/harmony/reflect-construct.js View 1 chunk +0 lines, -378 lines 0 comments Download
D test/mjsunit/harmony/reflect-define-property.js View 1 chunk +0 lines, -1115 lines 0 comments Download
D test/mjsunit/harmony/reflect-get-own-property-descriptor.js View 1 chunk +0 lines, -123 lines 0 comments Download
D test/mjsunit/harmony/reflect-get-prototype-of.js View 1 chunk +0 lines, -139 lines 0 comments Download
D test/mjsunit/harmony/reflect-own-keys.js View 1 chunk +0 lines, -93 lines 0 comments Download
D test/mjsunit/harmony/reflect-prevent-extensions.js View 1 chunk +0 lines, -164 lines 0 comments Download
D test/mjsunit/harmony/reflect-set-prototype-of.js View 1 chunk +0 lines, -184 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-2219.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-2225.js View 1 chunk +0 lines, -76 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-576662.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-crbug-448730.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-crbug-461520.js View 1 chunk +0 lines, -20 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-lookup-transition.js View 1 chunk +0 lines, -14 lines 0 comments Download
M test/mjsunit/harmony/simd.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/readonly.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-505907.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-506956.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
adamk
4 years, 9 months ago (2016-03-18 20:24:20 UTC) #2
adamk
https://codereview.chromium.org/1815773002/diff/1/test/mjsunit/es6/proxies-function.js File test/mjsunit/es6/proxies-function.js (right): https://codereview.chromium.org/1815773002/diff/1/test/mjsunit/es6/proxies-function.js#newcode31 test/mjsunit/es6/proxies-function.js:31: // TODO(neis): These tests are temporarily commented out because ...
4 years, 9 months ago (2016-03-18 20:26:19 UTC) #3
neis
lgtm On 2016/03/18 20:26:19, adamk wrote: > https://codereview.chromium.org/1815773002/diff/1/test/mjsunit/es6/proxies-function.js > File test/mjsunit/es6/proxies-function.js (right): > > https://codereview.chromium.org/1815773002/diff/1/test/mjsunit/es6/proxies-function.js#newcode31 ...
4 years, 9 months ago (2016-03-21 09:40:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815773002/20001
4 years, 9 months ago (2016-03-21 18:55:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3275)
4 years, 9 months ago (2016-03-21 18:59:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815773002/20001
4 years, 9 months ago (2016-03-21 18:59:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 19:39:22 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:40:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/249bf75e0c99c0fee36cfbd09cad428129edd1c1
Cr-Commit-Position: refs/heads/master@{#34964}

Powered by Google App Engine
This is Rietveld 408576698