[DevTools] Move getFunctionDetails to native

third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
 
 DebuggerScript._pauseOnExceptionsState = DebuggerScript.PauseOnExceptionsState.DontPauseOnExceptions;
 Debug.clearBreakOnException();
 Debug.clearBreakOnUncaughtException();
 
 DebuggerScript.getAfterCompileScript = function(eventData)
 {
     return DebuggerScript._formatScript(eventData.script_.script_);
 }
 
+DebuggerScript._scopeTypeNames = {
+    0: "global",

[dgozman, 2016/03/18 23:27:55]

0 -> ScopeType.Global, etc.

[kozy, 2016/03/19 00:40:23]

Done.

+    1: "local",
+    2: "with",
+    3: "closure",
+    4: "catch",
+    5: "block",
+    6: "script",
+    __proto__: null
+};
+
 DebuggerScript.getFunctionScopes = function(fun)
 {
     var mirror = MakeMirror(fun);
     if (!mirror.isFunction())
         return null;
     var count = mirror.scopeCount();
     if (count == 0)
         return null;
     var result = [];
     for (var i = 0; i < count; i++) {
         var scopeDetails = mirror.scope(i).details();
         var scopeObject = DebuggerScript._buildScopeObject(scopeDetails.type(), scopeDetails.object());
         if (!scopeObject)
             continue;
         result.push({
-            type: scopeDetails.type(),
+            type: DebuggerScript._scopeTypeNames[scopeDetails.type()],
             object: scopeObject,
-            name: scopeDetails.name()
+            name: scopeDetails.name() || ""
         });
     }
     return result;
 }
 
 DebuggerScript.getGeneratorObjectDetails = function(object)
 {
     var mirror = MakeMirror(object, true /* transient */);
     if (!mirror.isGenerator())
         return null;
@@ skipping 346 matching lines @@
 
     function lazyScopeChain()
     {
         if (!scopeChain) {
             scopeChain = [];
             scopeStartLocations = [];
             scopeEndLocations = [];
             for (var i = 0, j = 0; i < scopeObjects.length; ++i) {
                 var scopeObject = DebuggerScript._buildScopeObject(scopeTypes[i], scopeObjects[i]);
                 if (scopeObject) {
                     scopeTypes[j] = scopeTypes[i];

[dgozman, 2016/03/18 23:27:55]

Wrap here to string.

[kozy, 2016/03/19 00:40:23]

Done.

                     scopeNames[j] = scopeNames[i];
                     scopeChain[j] = scopeObject;
 
                     var funcMirror = scopeFunctions ? MakeMirror(scopeFunctions[i]) : null;
                     if (!funcMirror || !funcMirror.isFunction())
                         funcMirror = new UnresolvedFunctionMirror(funcObject);
 
                     var script = funcMirror.script();
                     scopeStartLocations[j] = createLocation(script, scopeStartPositions[i]);
                     scopeEndLocations[j] = createLocation(script, scopeEndPositions[i]);
@@ skipping 203 matching lines @@
         "parentPromise": eventData.parentPromise().value(),
         "status": eventData.status()
     };
 }
 
 // We never resolve Mirror by its handle so to avoid memory leaks caused by Mirrors in the cache we disable it.
 ToggleMirrorCache(false);
 
 return DebuggerScript;
 })();