[MD] Fix bookmark bar painting bugs.

chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 1b63bccd6a92c17224007dfcc7bc46904b36157e..bce50607c1bb76f011d1c5d86c6b41e7bb6c7b0c 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -619,7 +619,6 @@ BookmarkBarView::BookmarkBarView(Browser* browser, BrowserView* browser_view)
   if (ui::MaterialDesignController::IsModeMaterial()) {
     // Don't let the bookmarks show on top of the location bar while animating.
     SetPaintToLayer(true);
-    layer()->SetFillsBoundsOpaquely(false);

[Evan Stade, 2016/03/18 19:02:04]

this is the part that I think may fix the text rendering bug (which is only
present on windows and looks like subpixel anti-aliasing on a transparent bg).
When I added this line I think I copy-pasted without sufficiently considering
whether it made sense. The bookmarks bar does fill its bounds opaquely, so it's
more correct not to do this.

[bruthig, 2016/03/18 19:40:32]

I'm skeptical here.  If the BookmarkButtonView is painting opaquely then how
will the underlying theme images be visible?

It would be worth while making sure some utility function isn't updating the
subpixel rendering property on those labels.  For example I noticed a drag and
drop util function (that captured the image for drag and drop) was updating
changing the subpixel rendering property without resetting it before it
finished.  I will continue looking for this example.

     layer()->SetMasksToBounds(true);
   }
 
@@ -2112,6 +2111,9 @@ void BookmarkBarView::UpdateAppearanceForTheme() {
       gfx::CreateVectorIcon(gfx::VectorIconId::OVERFLOW_CHEVRON, 8,
                             theme_provider->GetColor(
                                 ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON)));
+
+  // Redraw the background.
+  SchedulePaint();
 }
 
 bool BookmarkBarView::UpdateOtherAndManagedButtonsVisibility() {