chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js - Issue 1815733004: MD Settings: Certificate manager, hooking up all dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

Issue 1815733004: MD Settings: Certificate manager, hooking up all dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@certificates_basic_ui

Patch Set: Adding more tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js ('K') | « chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js ('k') | chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html » ('j') | chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js b/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

index e9da85e66c1baa85ebfeaebe59aae5d8a69d1036..e3667acbf3c552564c475590132eef4d46b2ab72 100644

--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

@@ -87,7 +87,9 @@ Polymer({

}.bind(this),

/** @param {!CertificatesError} error */

function(error) {

tommycli 2016/03/23 19:28:04 Nit: Same comment here, the indentation confused m

dpapad 2016/03/24 22:06:10 See previous response to similar comment.

- // TODO(dpapad): Display error here.

- });

+ this.$.dialog.close();

+ this.dispatchEvent(

+ new CustomEvent('certificates-error', {detail: error}));

+ }.bind(this));

});