Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

Issue 1815733004: MD Settings: Certificate manager, hooking up all dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@certificates_basic_ui
Patch Set: Address comments + rebase- Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
diff --git a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js b/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
index 019f8fd85d5ec5605e60c2f1911e407e69e3ab3c..3f911ec7bd9583680975a6500d5a68b054239ae6 100644
--- a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
+++ b/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
@@ -55,13 +55,15 @@ Polymer({
this.$.spinner.active = true;
this.browserProxy_.editCaCertificateTrust(
this.model.id, this.$.ssl.checked,
- this.$.email.checked, this.$.objSign.checked).then(function() {
- this.$.spinner.active = false;
- this.$.dialog.close();
- }.bind(this),
- /** @param {!CertificatesError} error */
- function(error) {
- // TODO(dpapad): Display error here.
- });
+ this.$.email.checked, this.$.objSign.checked).then(
+ function() {
+ this.$.spinner.active = false;
+ this.$.dialog.close();
+ }.bind(this),
+ /** @param {!CertificatesError} error */
+ function(error) {
+ this.$.dialog.close();
+ this.fire('certificates-error', error);
+ }.bind(this));
},
});
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698