Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js

Issue 1815733004: MD Settings: Certificate manager, hooking up all dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@certificates_basic_ui
Patch Set: Adding more tests. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A confirmation dialog allowing the user to delete various types 6 * @fileoverview A confirmation dialog allowing the user to delete various types
7 * of certificates. 7 * of certificates.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-certificate-delete-confirmation-dialog', 10 is: 'settings-certificate-delete-confirmation-dialog',
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 onCancelTap_: function() { 79 onCancelTap_: function() {
80 this.$.dialog.close(); 80 this.$.dialog.close();
81 }, 81 },
82 82
83 /** @private */ 83 /** @private */
84 onOkTap_: function() { 84 onOkTap_: function() {
85 this.browserProxy_.deleteCertificate(this.model.id).then(function() { 85 this.browserProxy_.deleteCertificate(this.model.id).then(function() {
86 this.$.dialog.close(); 86 this.$.dialog.close();
87 }.bind(this), 87 }.bind(this),
88 /** @param {!CertificatesError} error */ 88 /** @param {!CertificatesError} error */
89 function(error) { 89 function(error) {
tommycli 2016/03/23 19:28:04 Nit: Same comment here, the indentation confused m
dpapad 2016/03/24 22:06:10 See previous response to similar comment.
90 // TODO(dpapad): Display error here. 90 this.$.dialog.close();
91 }); 91 this.dispatchEvent(
92 new CustomEvent('certificates-error', {detail: error}));
93 }.bind(this));
92 }, 94 },
93 }); 95 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698