Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1815683002: Add pointer transition events to the touch test (Closed)

Created:
4 years, 9 months ago by Navid Zolghadr
Modified:
4 years, 9 months ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pointer transition events to the touch test Adding pointerout/over/enter/leave to one of the touch tests to make sure we do fire those in the case of pointerdown/up as well as pointerdown/cancel. BUG=595439 Committed: https://crrev.com/19bc10580a244fbb8bcc2876fcb3b3ce914aafe3 Cr-Commit-Position: refs/heads/master@{#382291}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointercancel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointercancel-expected.txt View 8 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Navid Zolghadr
4 years, 9 months ago (2016-03-18 17:19:37 UTC) #2
Rick Byers
LGTM, thanks!
4 years, 9 months ago (2016-03-18 19:25:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815683002/20001
4 years, 9 months ago (2016-03-21 14:20:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 15:25:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:27:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19bc10580a244fbb8bcc2876fcb3b3ce914aafe3
Cr-Commit-Position: refs/heads/master@{#382291}

Powered by Google App Engine
This is Rietveld 408576698