Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1815663002: Speed up PrototypeHasNoElements and drop the "fast" path before, it's now slower. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up PrototypeHasNoElements and drop the "fast" path before, it's now slower. BUG= Committed: https://crrev.com/536d8cbbad2d3e7a416365670122c7b9100fa5cd Cr-Commit-Position: refs/heads/master@{#34942}

Patch Set 1 #

Patch Set 2 : more cleanup #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -44 lines) Patch
M src/builtins.cc View 1 2 3 chunks +21 lines, -43 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-18 15:07:31 UTC) #2
Jakob Kummerow
lgtm https://codereview.chromium.org/1815663002/diff/120001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1815663002/diff/120001/src/builtins.cc#newcode245 src/builtins.cc:245: // Check that ther are not elements on ...
4 years, 9 months ago (2016-03-21 13:24:20 UTC) #8
Toon Verwaest
done
4 years, 9 months ago (2016-03-21 13:26:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815663002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815663002/140001
4 years, 9 months ago (2016-03-21 13:27:05 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:140001)
4 years, 9 months ago (2016-03-21 14:14:45 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 14:16:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/536d8cbbad2d3e7a416365670122c7b9100fa5cd
Cr-Commit-Position: refs/heads/master@{#34942}

Powered by Google App Engine
This is Rietveld 408576698