Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1815653002: Revert of Add traces for main omnibox providers (Closed)

Created:
4 years, 9 months ago by phoglund_chromium
Modified:
4 years, 9 months ago
CC:
chromium-reviews, Mark P
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add traces for main omnibox providers (patchset #1 id:1 of https://codereview.chromium.org/1805363002/ ) Reason for revert: I think the new category breaks SingleProcessTracingBrowserTest.TestMemoryInfra: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/52926/steps/browser_tests%20on%20Ubuntu-12.04/logs/SingleProcessTracingBrowserTest.TestMemoryInfra. It may be as simple as increasing MAX_CATEGORY_GROUPS but I'll leave that to the CL author. 14141:14175:0318/032221:FATAL:trace_log.cc(537)] Check failed: category_index < MAX_CATEGORY_GROUPS. must increase MAX_CATEGORY_GROUPS #0 0x7f9a37d4574e base::debug::StackTrace::StackTrace() #1 0x7f9a37da5d5f logging::LogMessage::~LogMessage() #2 0x7f9a37f4910c base::trace_event::TraceLog::GetCategoryGroupEnabledInternal() #3 0x7f9a37f48daa base::trace_event::TraceLog::GetCategoryGroupEnabled() #4 0x7f9a2d3c1ef1 storage::FileSystemUsageCache::CloseCacheFiles() #5 0x7f9a2d3c1e34 storage::FileSystemUsageCache::~FileSystemUsageCache() #6 0x7f9a2d42aaf7 base::DeleteHelper<>::DoDelete() Original issue's description: > Add traces for main omnibox providers > > Add trace events for main omnibox providers. They are useful when > analyzing problems with omnibox slow response and lagginess while > typing, like issue 178705. > > Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65 > Cr-Commit-Position: refs/heads/master@{#381913} TBR=pkasting@chromium.org,mpearson@chromium.org,a-v-y@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/aa5d4202236ed392bdeb5fc80a2aa94a618fbff7 Cr-Commit-Position: refs/heads/master@{#381963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M components/omnibox/browser/autocomplete_controller.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M components/omnibox/browser/bookmark_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/omnibox/browser/history_quick_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/omnibox/browser/keyword_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/omnibox/browser/shortcuts_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
phoglund_chromium
Created Revert of Add traces for main omnibox providers
4 years, 9 months ago (2016-03-18 14:35:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815653002/1
4 years, 9 months ago (2016-03-18 14:35:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 14:37:03 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 14:39:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5d4202236ed392bdeb5fc80a2aa94a618fbff7
Cr-Commit-Position: refs/heads/master@{#381963}

Powered by Google App Engine
This is Rietveld 408576698