DescriptionRevert of Add traces for main omnibox providers (patchset #1 id:1 of https://codereview.chromium.org/1805363002/ )
Reason for revert:
I think the new category breaks SingleProcessTracingBrowserTest.TestMemoryInfra: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/52926/steps/browser_tests%20on%20Ubuntu-12.04/logs/SingleProcessTracingBrowserTest.TestMemoryInfra. It may be as simple as increasing MAX_CATEGORY_GROUPS but I'll leave that to the CL author.
14141:14175:0318/032221:FATAL:trace_log.cc(537)] Check failed: category_index < MAX_CATEGORY_GROUPS. must increase MAX_CATEGORY_GROUPS
#0 0x7f9a37d4574e base::debug::StackTrace::StackTrace()
#1 0x7f9a37da5d5f logging::LogMessage::~LogMessage()
#2 0x7f9a37f4910c base::trace_event::TraceLog::GetCategoryGroupEnabledInternal()
#3 0x7f9a37f48daa base::trace_event::TraceLog::GetCategoryGroupEnabled()
#4 0x7f9a2d3c1ef1 storage::FileSystemUsageCache::CloseCacheFiles()
#5 0x7f9a2d3c1e34 storage::FileSystemUsageCache::~FileSystemUsageCache()
#6 0x7f9a2d42aaf7 base::DeleteHelper<>::DoDelete()
Original issue's description:
> Add traces for main omnibox providers
>
> Add trace events for main omnibox providers. They are useful when
> analyzing problems with omnibox slow response and lagginess while
> typing, like issue 178705.
>
> Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
> Cr-Commit-Position: refs/heads/master@{#381913}
TBR=pkasting@chromium.org,mpearson@chromium.org,a-v-y@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/aa5d4202236ed392bdeb5fc80a2aa94a618fbff7
Cr-Commit-Position: refs/heads/master@{#381963}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|