Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1815643002: Introduce DocumentOrShadowRoot Mixin (Closed)

Created:
4 years, 9 months ago by hayato
Modified:
4 years, 9 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@debug
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -16 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 3 chunks +1 line, -10 lines 0 comments Download
A third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h View 1 chunk +53 lines, -0 lines 2 comments Download
A third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.idl View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815643002/1
4 years, 9 months ago (2016-03-18 09:03:04 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/37852) cast_shell_linux on ...
4 years, 9 months ago (2016-03-18 09:06:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815643002/1
4 years, 9 months ago (2016-03-18 09:25:16 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/37811) android_chromium_gn_compile_rel on ...
4 years, 9 months ago (2016-03-18 09:29:00 UTC) #9
hayato
fix typo
4 years, 9 months ago (2016-03-18 09:47:46 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815643002/20001
4 years, 9 months ago (2016-03-18 09:47:55 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 10:59:45 UTC) #14
hayato
PTAL
4 years, 9 months ago (2016-03-22 03:07:13 UTC) #16
kochi
Could you also fix typo in the title and the description? s/DocumenOrShadowRoot/DocumentOrShadowRoot/ https://codereview.chromium.org/1815643002/diff/20001/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h File third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h ...
4 years, 9 months ago (2016-03-22 03:43:56 UTC) #17
hayato
Fixed typo in the subject. https://codereview.chromium.org/1815643002/diff/20001/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h File third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h (right): https://codereview.chromium.org/1815643002/diff/20001/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h#newcode17 third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:17: return document.activeElement(); On 2016/03/22 ...
4 years, 9 months ago (2016-03-22 03:50:08 UTC) #19
kochi
On 2016/03/22 03:50:08, hayato wrote: > Fixed typo in the subject. > > https://codereview.chromium.org/1815643002/diff/20001/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h > ...
4 years, 9 months ago (2016-03-22 03:53:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815643002/20001
4 years, 9 months ago (2016-03-22 04:07:31 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 05:39:05 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 05:41:55 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e97f9b878e58270e4a8d719800d16650c95459e
Cr-Commit-Position: refs/heads/master@{#382515}

Powered by Google App Engine
This is Rietveld 408576698