Remove --ash-disable-overview-mode

ash/focus_cycler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/focus_cycler.h"
 
 #include "ash/shell.h"
 #include "ash/wm/mru_window_tracker.h"
-#include "ash/wm/window_cycle_controller.h"
+#include "ash/wm/window_state.h"
 #include "ash/wm/window_util.h"
 #include "ui/aura/client/activation_client.h"
 #include "ui/aura/window.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/focus/focus_search.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 namespace {
@@ skipping 50 matching lines @@
       index = (index + 1) % count;
     else
       index = ((index - 1) + count) % count;
 
     // Ensure that we don't loop more than once.
     if (index == start_index)
       break;
 
     if (index == browser_index) {
       // Activate the most recently active browser window.
-      ash::Shell::GetInstance()->window_cycle_controller()->HandleCycleWindow(
-          WindowCycleController::FORWARD, false);
-
-      // Rotate pane focus within that window.
-      aura::Window* window = ash::wm::GetActiveWindow();
-      if (!window)
+      MruWindowTracker::WindowList mru_windows(
+          Shell::GetInstance()->mru_window_tracker()->BuildMruWindowList());
+      if (mru_windows.empty())
         break;
+      aura::Window* window(mru_windows[mru_windows.size() > 1 ? 1 : 0]);
+      wm::GetWindowState(window)->Activate();

[oshima, 2014/02/28 17:54:39]

So this case, we're activating the top most (if there is only one) anyway
because the window may be minimized?

[flackr, 2014/03/11 19:55:07]

Looking into this we only ever expect to cycle focus between the status area and
the last active browser. I've updated the test to reflect this and always used
.front().

       views::Widget* widget = views::Widget::GetWidgetForNativeWindow(window);
       if (!widget)
         break;
       views::FocusManager* focus_manager = widget->GetFocusManager();
       focus_manager->ClearFocus();
       focus_manager->RotatePaneFocus(
           direction == BACKWARD ?
               views::FocusManager::kBackward : views::FocusManager::kForward,
           views::FocusManager::kWrap);
       break;
     } else {
       if (FocusWidget(widgets_[index]))
         break;
     }
   }
 }
 
 bool FocusCycler::FocusWidget(views::Widget* widget) {
   // Note: It is not necessary to set the focus directly to the pane since that
   // will be taken care of by the widget activation.
   widget_activating_ = widget;
   widget->Activate();
   widget_activating_ = NULL;
   return widget->IsActive();
 }
 
 }  // namespace internal
 
 }  // namespace ash