Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 1815623004: Remove Hung plugin detector (Closed)

Created:
4 years, 9 months ago by piman
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_windowed_plugins
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Hung plugin detector It's not needed now that windowed plugins are gone. BUG=493212 Committed: https://crrev.com/581baa18e98231cb9219f17a909da04174fa11c3 Cr-Commit-Position: refs/heads/master@{#382136}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -819 lines) Patch
D chrome/browser/hang_monitor/hung_plugin_action.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/hang_monitor/hung_plugin_action.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/hang_monitor/hung_window_detector.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/hang_monitor/hung_window_detector.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M chrome/browser/ui/browser_view_prefs.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 4 chunks +0 lines, -43 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/worker_thread_ticker.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/common/worker_thread_ticker.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/common/worker_thread_ticker_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
piman
4 years, 9 months ago (2016-03-18 19:52:23 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-18 20:38:28 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1815593002 Patch 60001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-18 20:41:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815623004/1
4 years, 9 months ago (2016-03-18 21:34:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/109320)
4 years, 9 months ago (2016-03-18 21:52:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815623004/20001
4 years, 9 months ago (2016-03-18 22:35:32 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 00:28:14 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:30:07 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/581baa18e98231cb9219f17a909da04174fa11c3
Cr-Commit-Position: refs/heads/master@{#382136}

Powered by Google App Engine
This is Rietveld 408576698