sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart - Issue 18156006: Fix minified signature generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 18156006: Fix minified signature generation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Restrict use of fixed names to this-elements. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

index e8abbb2a97ff4ae40ef4b5d1c29886b1c66cf337..396d510c88a60adda396d87cb337a4fdd8e4b79f 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

@@ -1367,7 +1367,9 @@ class CodeEmitterTask extends CompilerTask {

Element thisElement =

closureData.freeVariableMapping[closureData.thisElement];

if (thisElement != null) {

- String thisName = backend.namer.getName(thisElement);

+ String thisName = thisElement.hasFixedBackendName()

karlklose 2013/07/04 09:54:09 Is that always the case? Add an assert then?

Johnni Winther 2013/07/04 12:10:38 It seems so.

+ ? thisElement.fixedBackendName()

+ : backend.namer.getName(thisElement);

thisAccess = 'this.$thisName';

}

« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »