Issue 18156005: cc: Remove unused WebKit includes.

Issue 18156005: cc: Remove unused WebKit includes. (Closed)

Created:
7 years, 5 months ago by tfarina

Modified:
7 years, 5 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Remove unused WebKit includes. BUG=None TEST=cc_unittests R=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209941

Patch Set 2 : forward declare it #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	cc/output/gl_renderer.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	cc/output/gl_renderer.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/output/gl_renderer_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tfarina

Sorry, nothing excited. :/ Noticed while grepping for WebGraphicsMemoryAllocation.

7 years, 5 months ago (2013-07-02 14:02:58 UTC) #1

danakj

LGTM https://codereview.chromium.org/18156005/diff/1/cc/output/gl_renderer.h File cc/output/gl_renderer.h (left): https://codereview.chromium.org/18156005/diff/1/cc/output/gl_renderer.h#oldcode21 cc/output/gl_renderer.h:21: #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h" Could you forward declare this class, ...

7 years, 5 months ago (2013-07-02 15:59:00 UTC) #2

tfarina

https://codereview.chromium.org/18156005/diff/1/cc/output/gl_renderer.h File cc/output/gl_renderer.h (left): https://codereview.chromium.org/18156005/diff/1/cc/output/gl_renderer.h#oldcode21 cc/output/gl_renderer.h:21: #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h" On 2013/07/02 15:59:00, danakj wrote: > Could ...

7 years, 5 months ago (2013-07-03 03:04:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/18156005/12001

7 years, 5 months ago (2013-07-03 03:14:31 UTC) #4

Message was sent while issue was closed.

Change committed as 209941

Expand Messages | Collapse Messages