Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1815563006: Remove [SG]etParentNativeViewAccessible (Closed)

Created:
4 years, 9 months ago by piman
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_plugin_quirks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [SG]etParentNativeViewAccessible It's dead code: 1- RenderWidgetHostImpl::GetParentNativeViewAccessible is never called, so by extension all the RenderWidgetHostDelegate implmentations are not called 2- Because of 1, WebContentsImpl::accessible_parent_ is set but never used, so can be removed 3- All the RenderWidgetHostView*::SetParentNativeViewAccessible are trivial and can be removed 4- Because of 2 and 3, WebContentsImpl::SetParentNativeViewAccessible does nothing any more, can be removed. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/45cf0b58103c62895d4e4c8223e798bf84a42345 Cr-Commit-Position: refs/heads/master@{#382796}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -174 lines) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 1 chunk +1 line, -16 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 chunks +0 lines, -19 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
piman
4 years, 9 months ago (2016-03-18 21:06:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563006/1
4 years, 9 months ago (2016-03-18 21:06:54 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/109321) ios_dbg_simulator_gn on ...
4 years, 9 months ago (2016-03-18 21:11:30 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563006/1
4 years, 9 months ago (2016-03-18 21:35:45 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/184797)
4 years, 9 months ago (2016-03-18 22:29:28 UTC) #11
sky
LGTM
4 years, 9 months ago (2016-03-18 22:34:15 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 1813143002 Patch 60001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-18 22:39:02 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563006/20001
4 years, 9 months ago (2016-03-19 00:39:56 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/6751) ios_dbg_simulator_ninja on ...
4 years, 9 months ago (2016-03-19 00:43:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563006/40001
4 years, 9 months ago (2016-03-22 20:44:54 UTC) #23
commit-bot: I haz the power
Failed to apply patch for content/browser/frame_host/render_widget_host_view_child_frame.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-22 22:16:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563006/40001
4 years, 9 months ago (2016-03-23 05:30:58 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 05:36:02 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 05:37:59 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/45cf0b58103c62895d4e4c8223e798bf84a42345
Cr-Commit-Position: refs/heads/master@{#382796}

Powered by Google App Engine
This is Rietveld 408576698