Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1815563005: [Android] Run lint using a cache in the output directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: prereview 2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/zip.gni") 7 import("//build/config/zip.gni")
8 import("//third_party/ijar/ijar.gni") 8 import("//third_party/ijar/ijar.gni")
9 9
10 assert(is_android) 10 assert(is_android)
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 suppressions_file, 47 suppressions_file,
48 android_manifest, 48 android_manifest,
49 jar_path, 49 jar_path,
50 ] + java_files 50 ] + java_files
51 51
52 outputs = [ 52 outputs = [
53 config_path, 53 config_path,
54 result_path, 54 result_path,
55 ] 55 ]
56 56
57 if (!defined(deps)) {
agrieve 2016/03/19 00:12:54 nit: you can save a couple lines if you put "deps
jbudorick 2016/03/19 00:57:42 Done.
58 deps = []
59 }
60 deps += [ "//build/android:prepare_lint_cache" ]
61
57 rebased_java_files = rebase_path(java_files, root_build_dir) 62 rebased_java_files = rebase_path(java_files, root_build_dir)
58 63
59 args = [ 64 args = [
60 "--lint-path=$rebased_android_sdk_root/tools/lint", 65 "--lint-path=$rebased_android_sdk_root/tools/lint",
61 "--config-path", 66 "--config-path",
62 rebase_path(suppressions_file, root_build_dir), 67 rebase_path(suppressions_file, root_build_dir),
63 "--manifest-path", 68 "--manifest-path",
64 rebase_path(android_manifest, root_build_dir), 69 rebase_path(android_manifest, root_build_dir),
65 "--product-dir=.", 70 "--product-dir=.",
66 "--jar-path", 71 "--jar-path",
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2167 ] 2172 ]
2168 args = [ 2173 args = [
2169 "--depfile", 2174 "--depfile",
2170 rebase_path(depfile, root_build_dir), 2175 rebase_path(depfile, root_build_dir),
2171 "--script-output-path", 2176 "--script-output-path",
2172 rebase_path(generated_script, root_build_dir), 2177 rebase_path(generated_script, root_build_dir),
2173 ] 2178 ]
2174 args += test_runner_args 2179 args += test_runner_args
2175 } 2180 }
2176 } 2181 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698