Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1815563004: Remove iOS ifdefs in src/content. (Closed)

Created:
4 years, 9 months ago by jam
Modified:
4 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, yusukes+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, miu+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove iOS ifdefs in src/content. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/e1f453c8038dd60f17847dc37603c64835f9d865 Cr-Commit-Position: refs/heads/master@{#382296}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -219 lines) Patch
M content/app/content_main_runner.cc View 1 2 22 chunks +22 lines, -43 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_context.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 27 chunks +7 lines, -45 lines 0 comments Download
M content/browser/browser_main_runner.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/child_process_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_jpeg_decode_accelerator_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/content_main_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/navigation_controller.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/browser/resource_context.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_utils.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/test_content_client_initializer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/unittest_test_suite.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/unittest_test_suite.cc View 3 chunks +1 line, -8 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_suite.cc View 6 chunks +3 lines, -13 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_content_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jam
4 years, 9 months ago (2016-03-18 22:57:58 UTC) #3
scottmg
https://codereview.chromium.org/1815563004/diff/20001/content/app/content_main_runner.cc File content/app/content_main_runner.cc (left): https://codereview.chromium.org/1815563004/diff/20001/content/app/content_main_runner.cc#oldcode234 content/app/content_main_runner.cc:234: #if !defined(OS_IOS) && !defined(CHROME_MULTIPLE_DLL_BROWSER) same https://codereview.chromium.org/1815563004/diff/20001/content/app/content_main_runner.cc File content/app/content_main_runner.cc (right): ...
4 years, 9 months ago (2016-03-18 23:07:40 UTC) #4
jam
https://codereview.chromium.org/1815563004/diff/20001/content/app/content_main_runner.cc File content/app/content_main_runner.cc (right): https://codereview.chromium.org/1815563004/diff/20001/content/app/content_main_runner.cc#newcode131 content/app/content_main_runner.cc:131: base::LazyInstance<ContentGpuClient> On 2016/03/18 23:07:39, scottmg wrote: > I think ...
4 years, 9 months ago (2016-03-19 03:22:17 UTC) #5
scottmg
lgtm
4 years, 9 months ago (2016-03-20 20:30:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815563004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815563004/40001
4 years, 9 months ago (2016-03-21 14:35:32 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-21 15:51:43 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e1f453c8038dd60f17847dc37603c64835f9d865 Cr-Commit-Position: refs/heads/master@{#382296}
4 years, 9 months ago (2016-03-21 15:52:55 UTC) #11
blundell
4 years, 9 months ago (2016-03-24 09:27:16 UTC) #12
Message was sent while issue was closed. 
On 2016/03/21 15:52:55, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/e1f453c8038dd60f17847dc37603c64835f9d865
> Cr-Commit-Position: refs/heads/master@{#382296}

Thanks!

Powered by Google App Engine
This is Rietveld 408576698