Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 1815563002: MacViews: Enable acceptsFirstMouse for BridgedContentView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Linting, update comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm
index 6022a44723bf99d9873d04bd6dcbebdb7bc66697..5f7427a1e11217ec7ecd8155d1bd66ace562e1a2 100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -868,6 +868,13 @@ gfx::Rect GetFirstRectForRangeHelper(const ui::TextInputClient* client,
textInputClient_->ConfirmCompositionText();
}
+// To maximise consistency with the Cocoa browser (mac_views_browser=0), accept
tapted 2016/03/17 23:57:35 nit: maximize
Patti Lor 2016/03/18 00:19:39 Done.
+// mouse clicks immediately so that clicking Chrome from an inactive window will
tapted 2016/03/17 23:57:35 `clicking Chrome from an` -> `clicking on`
Patti Lor 2016/03/18 00:19:39 Done.
+// allow the event to be processed.
tapted 2016/03/17 23:57:34 processed, rather than merely activate the window.
Patti Lor 2016/03/18 00:19:39 Done.
+- (BOOL)acceptsFirstMouse:(NSEvent*)theEvent {
tapted 2016/03/17 23:57:35 So for ordering, this should come after // NSView
Patti Lor 2016/03/18 00:19:39 Done.
+ return YES;
+}
+
- (NSArray*)validAttributesForMarkedText {
return @[];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698