Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1815523002: [MD settings] remove breadcrumb code (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove breadcrumb code The settings breadcrumb feature is being removed. That location on the title bar will become the search within settings. This CL removes the breadcrumb code. BUG=589630 Committed: https://crrev.com/23b8e20ccb791a82b3cf1e5432a4b51b3b0ab375 Cr-Commit-Position: refs/heads/master@{#381860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -144 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_router.js View 26 chunks +1 line, -57 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/settings/settings_ui/breadcrumb.css View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/settings/settings_ui/breadcrumb.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/settings/settings_ui/breadcrumb.js View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dschuyler
Rather than growing CL https://codereview.chromium.org/1812823005/ This CL focuses on just removing the breadcrumb code.
4 years, 9 months ago (2016-03-17 22:53:08 UTC) #2
tommycli
lgtm lgtm finds no more instances of subpageTitles
4 years, 9 months ago (2016-03-17 23:09:10 UTC) #3
tommycli
On 2016/03/17 23:09:10, tommycli wrote: > lgtm > > lgtm finds no more instances of ...
4 years, 9 months ago (2016-03-17 23:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815523002/1
4 years, 9 months ago (2016-03-18 00:05:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 01:10:37 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 01:11:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23b8e20ccb791a82b3cf1e5432a4b51b3b0ab375
Cr-Commit-Position: refs/heads/master@{#381860}

Powered by Google App Engine
This is Rietveld 408576698