Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1815443002: Revert of Use PhantomReference for CleanupReference (Closed)

Created:
4 years, 9 months ago by boliu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use PhantomReference for CleanupReference (patchset #1 id:1 of https://codereview.chromium.org/1802233002/ ) Reason for revert: Found out that PhantomReference can survive (ie not get enqueued) a GC pass. Tested on Android M. This would cause unacceptable memory regressions for apps that relies on gc to clean up webview. Original issue's description: > android: Use PhantomReference for CleanupReference > > PhantomReference is less of a burden on dalvik/art gc systems. > > Committed: https://crrev.com/9b1b3599500eca2b8d664714edf6b6771a789123 > Cr-Commit-Position: refs/heads/master@{#381173} TBR=dtrainor@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/43f4806331fd76d86e68eea634f2d5ae8cd39cc7 Cr-Commit-Position: refs/heads/master@{#381817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/common/CleanupReference.java View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
boliu
Created Revert of Use PhantomReference for CleanupReference
4 years, 9 months ago (2016-03-17 19:15:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 19:15:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 19:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 20:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 20:31:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 21:02:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 21:31:54 UTC) #7
David Trainor- moved to gerrit
lgtm
4 years, 9 months ago (2016-03-17 21:56:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 22:02:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815443002/1
4 years, 9 months ago (2016-03-17 22:32:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 22:43:29 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:45:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43f4806331fd76d86e68eea634f2d5ae8cd39cc7
Cr-Commit-Position: refs/heads/master@{#381817}

Powered by Google App Engine
This is Rietveld 408576698