Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 181543003: Proof of concept: API for doing only one parsing pass instead of first preparsing and then parsing. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Proof of concept: API for doing only one parsing pass instead of first preparsing and then parsing. It will read the data only once, and produce the same data preparsing used to produce. The data can be saved in the cache if the upper layer wants so. When Blink calls the preparsing API, it will always call the parsing API right after. There's no reason why Parser couldn't produce it during the actual parsing pass. BUG=

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : fix: don't produce too much data #

Patch Set 5 : rebased -- this applies to r19832 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -52 lines) Patch
M include/v8.h View 1 2 3 4 3 chunks +46 lines, -7 lines 0 comments Download
M src/api.cc View 1 2 3 4 4 chunks +47 lines, -4 lines 0 comments Download
M src/compiler.h View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 4 chunks +12 lines, -9 lines 0 comments Download
M src/parser.h View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 3 4 11 chunks +47 lines, -16 lines 0 comments Download
M src/preparser.h View 1 2 3 4 5 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
6 years, 9 months ago (2014-02-27 10:55:44 UTC) #1
svenpanne@, wdyt about adding API for doing only one parsing pass (and producing
the same data that PreParser used to produce on the go)? Seems wasteful to do
two passes when we could get away with one. (Blink always parses right after it
has preparsed.)

Powered by Google App Engine
This is Rietveld 408576698