Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 18154004: Replace custom builtin invocation instructions by a generic version (Closed)

Created:
7 years, 5 months ago by oliv
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Replace custom builtin invocation instructions by a generic version BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15582

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address review #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -302 lines) Patch
M src/arm/lithium-arm.h View 1 4 chunks +0 lines, -30 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
M src/hydrogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 3 chunks +14 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 3 chunks +0 lines, -51 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 2 chunks +0 lines, -12 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 2 chunks +0 lines, -32 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 4 chunks +0 lines, -34 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 2 chunks +0 lines, -18 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
M src/x64/lithium-x64.h View 1 4 chunks +0 lines, -30 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 5 months ago (2013-07-05 11:14:43 UTC) #1
Michael Starzinger
LGTM with one comment. Nice cleanup. https://codereview.chromium.org/18154004/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/18154004/diff/2001/src/hydrogen.cc#newcode8300 src/hydrogen.cc:8300: HInstruction* instr = ...
7 years, 5 months ago (2013-07-05 13:47:49 UTC) #2
oliv
7 years, 5 months ago (2013-07-10 09:02:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r15582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698