Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1815393002: Return complete closure bundles from IncrementalCache. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Return complete closure bundles from IncrementalCache. Resynthesizer requires to be ready to provide information about any library in the closure, so we need to get all or nothing from the cache. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5e9a068c5752ebd3b3370bc04bcc54c55c394666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -86 lines) Patch
M pkg/analyzer/lib/src/summary/incremental_cache.dart View 5 chunks +90 lines, -27 lines 0 comments Download
M pkg/analyzer/test/src/summary/incremental_cache_test.dart View 4 chunks +99 lines, -59 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
scheglov
4 years, 9 months ago (2016-03-18 22:00:39 UTC) #1
Paul Berry
lgtm
4 years, 9 months ago (2016-03-21 17:11:24 UTC) #4
scheglov
4 years, 9 months ago (2016-03-21 17:28:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e9a068c5752ebd3b3370bc04bcc54c55c394666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698