Attach requestId to resource fetch trace

Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch event. Adding the requestId to resource fetch is the first step.

BUG=

Committed: https://crrev.com/e192fbd56bf3998966d62e35b130e346610d5dd7
Cr-Commit-Position: refs/heads/master@{#383834}

[paulirish, 2016-03-23 22:31:32]

paulirish@chromium.org changed reviewers:
+ caseq@chromium.org

[Nate Chapin, 2016-03-23 22:43:07]

japhet@chromium.org changed reviewers:
+ japhet@chromium.org

[Nate Chapin, 2016-03-23 22:43:07]

https://codereview.chromium.org/1815383003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/1815383003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:38: #include
"core/inspector/IdentifiersFactory.h"
This is a layering violation: core/fetch/ isn't allowed to include files from
core/inspector.

One option might be to move the trace event in question to
FrameFetchContext::willStartLoadingResource()?

[paulirish, 2016-03-23 23:08:48]

> One option might be to move the trace event in question to
FrameFetchContext::willStartLoadingResource()?

that works for me.

[dproy-google, 2016-03-24 00:48:05]

Moved call to FrameFetchContext. Thanks for the tip! Can you take another look?

[Nate Chapin, 2016-03-28 18:44:08]

lgtm

[chiniforooshan, 2016-03-29 20:14:53]

The CQ bit was checked by chiniforooshan@chromium.org

[chiniforooshan, 2016-03-29 20:15:06]

The CQ bit was unchecked by chiniforooshan@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:15:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815383003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815383003/20001

[chiniforooshan, 2016-03-29 20:15:22]

The CQ bit was checked by chiniforooshan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 20:15:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815383003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815383003/20001

[commit-bot: I haz the power, 2016-03-29 21:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 21:25:29]

Dry run: This issue passed the CQ dry run.

[dproy-google, 2016-03-29 21:26:00]

The CQ bit was checked by dproy@google.com

[dproy-google, 2016-03-29 21:26:19]

The CQ bit was unchecked by dproy@google.com

[dproy-google, 2016-03-29 21:29:31]

Description was changed from

==========
Attach requestId to resource fetch trace

BUG=
==========

to

==========
Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch
event. Adding the requestId to resource fetch is the first step.

BUG=
==========

[dproy-google, 2016-03-29 21:29:36]

The CQ bit was checked by dproy@google.com

[commit-bot: I haz the power, 2016-03-29 21:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815383003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815383003/20001

[commit-bot: I haz the power, 2016-03-29 21:35:51]

Description was changed from

==========
Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch
event. Adding the requestId to resource fetch is the first step.

BUG=
==========

to

==========
Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch
event. Adding the requestId to resource fetch is the first step.

BUG=
==========

[commit-bot: I haz the power, 2016-03-29 21:35:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 21:37:07]

Description was changed from

==========
Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch
event. Adding the requestId to resource fetch is the first step.

BUG=
==========

to

==========
Attach requestId to resource fetch trace

We want to connect the source of a resource request with the resource fetch
event. Adding the requestId to resource fetch is the first step.

BUG=

Committed: https://crrev.com/e192fbd56bf3998966d62e35b130e346610d5dd7
Cr-Commit-Position: refs/heads/master@{#383834}
==========

[commit-bot: I haz the power, 2016-03-29 21:37:08]

Patchset 2 (id:??) landed as
https://crrev.com/e192fbd56bf3998966d62e35b130e346610d5dd7
Cr-Commit-Position: refs/heads/master@{#383834}