storage/browser/fileapi/local_file_stream_reader.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/local_file_stream_reader.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/fileapi/local_file_stream_reader.cc

diff --git a/storage/browser/fileapi/local_file_stream_reader.cc b/storage/browser/fileapi/local_file_stream_reader.cc

index c6bfbbdc80d92eb319b04ee085494d40ff3a4bd3..74a9cc9bac2432fc7f81f3d465e173bb55e10b99 100644

--- a/storage/browser/fileapi/local_file_stream_reader.cc

+++ b/storage/browser/fileapi/local_file_stream_reader.cc

@@ -43,8 +43,8 @@ int LocalFileStreamReader::Read(net::IOBuffer* buf, int buf_len,

if (stream_impl_)

return stream_impl_->Read(buf, buf_len, callback);

return Open(base::Bind(&LocalFileStreamReader::DidOpenForRead,

- weak_factory_.GetWeakPtr(),

- make_scoped_refptr(buf), buf_len, callback));

+ weak_factory_.GetWeakPtr(), base::RetainedRef(buf),

+ buf_len, callback));

}

int64_t LocalFileStreamReader::GetLength(